-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix for MenuFlyoutItem displaying icon in monochrome instead of original colors #32522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SyedAbdulAzeemSF4852
wants to merge
4
commits into
dotnet:main
Choose a base branch
from
SyedAbdulAzeemSF4852:fix-16119
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f96b9a4
[Windows] Fix for MenuFlyoutItem with FileImageSource not displaying …
SyedAbdulAzeemSF4852 000d59d
Added a test case
SyedAbdulAzeemSF4852 236a3c5
Added the fix for MenuFlyoutSubItem and updated the test case
SyedAbdulAzeemSF4852 e2af807
Add baseline snapshot for Windows platform
SyedAbdulAzeemSF4852 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 16119, "MenuFlyoutItem with FileImageSource displays icon in monochrome instead of original colors", PlatformAffected.UWP)] | ||
| public class Issue16119 : TestShell | ||
| { | ||
| protected override void Init() | ||
| { | ||
| MenuBarItem menuBarItem = new MenuBarItem { Text = "Menu Flyout Item" }; | ||
|
|
||
| MenuFlyoutItem menuFlyoutItem = new MenuFlyoutItem | ||
| { | ||
| Text = "Hello World", | ||
| IconImageSource = new FileImageSource { File = "small_dotnet_bot.png" } | ||
| }; | ||
| menuBarItem.Add(menuFlyoutItem); | ||
|
|
||
| MenuFlyoutSubItem menuFlyoutSubItem = new MenuFlyoutSubItem | ||
| { | ||
| Text = "Sub Menu", | ||
| IconImageSource = new FileImageSource { File = "small_dotnet_bot.png" } | ||
| }; | ||
|
|
||
| menuFlyoutSubItem.Add(new MenuFlyoutItem | ||
| { | ||
| Text = "Sub Item 1", | ||
| IconImageSource = new FileImageSource { File = "small_dotnet_bot.png" } | ||
| }); | ||
|
|
||
| menuBarItem.Add(menuFlyoutSubItem); | ||
| MenuBarItems.Add(menuBarItem); | ||
|
|
||
| VerticalStackLayout layout = new VerticalStackLayout | ||
| { | ||
| Padding = new Thickness(30, 0), | ||
| Spacing = 25, | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| AutomationId = "Issue16119DescriptionLabel", | ||
| Text = "The test passes if the MenuFlyoutItem and MenuFlyoutSubItem icons are in original color instead of monochrome", | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| FontSize = 12 | ||
| }, | ||
| } | ||
| }; | ||
|
|
||
| AddContentPage(new ContentPage { Content = layout }); | ||
| FlyoutBehavior = FlyoutBehavior.Disabled; | ||
| } | ||
| } |
27 changes: 27 additions & 0 deletions
27
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16119.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #if WINDOWS //Menu bar items only for desktop apps. For more information : https://learn.microsoft.com/en-us/dotnet/maui/user-interface/menu-bar?view=net-maui-9.0 | ||
| //On MacCatalyst, menu items are part of the native macOS menu bar (e.g., Apple, File, Edit) at the top of the screen. So this is not implemented for Mac | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue16119 : _IssuesUITest | ||
| { | ||
| public override string Issue => "MenuFlyoutItem with FileImageSource displays icon in monochrome instead of original colors"; | ||
|
|
||
| public Issue16119(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Page)] | ||
| public void VerifyMenuFlyoutIconDisplaysOriginalColor() | ||
| { | ||
| App.WaitForElement("Issue16119DescriptionLabel"); | ||
| App.Tap("Menu Flyout Item"); | ||
|
|
||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| #endif |
Binary file added
BIN
+14.3 KB
...ses.WinUI.Tests/snapshots/windows/VerifyMenuFlyoutIconDisplaysOriginalColor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.