-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Several changes to reduce allocations #11273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to #11160 |
Is the plan to split this PR into several smaller ones still in place please? |
…rndt/reduceAllocations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the whole changese and do not have any strong concerns, but it's a bigger PR - so I want one more more detailed look before I sign-off
src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Curious about thoughts on splitting this PR. I can split it up primarily based on file if that's desired. |
This one was carved out into smaller ones that are currently being processed. |
Fixes #
Context
There is an appreciable amount of time all of the MSBuild process nodes spend doing GC during a build. Taking steps to reduce allocations. This PR contains a mix of approaches that reduce allocations in several areas.
Changes Made
Testing
Notes