-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update to latest maintenance-packages #11655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
While 0457980 just got merged, some of the previously released packages had issues that got fixed with the latest release. Also add entries for System.Buffers and System.Numerics.Vectors so that transitive pinning moves them to latest.
|
Would you mind resolving the conflicts? There were things in main that were very different. |
|
The MSBuild team reverted the previous change. I'm waiting for @rainersigwald to figure out the right path forward (offline Teams chat group). |
|
@rainersigwald as asked offline, I assume this PR will be blocked for some time until we can get the VS inbox assemblies updated? |
|
Yes, I expect we should have window to start working on that after the internal 17.14 branch stuff, probably mid-to-late this week? |
|
@rainersigwald any update here? Can we update to the latest versions now? |
|
experimental insertion - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/649634 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates maintenance packages to their latest versions to resolve issues found in previously released packages. The update affects assembly binding redirects and package version definitions to ensure transitive dependencies are pinned to the latest stable versions.
- Updates multiple system packages to their latest maintenance versions (Microsoft.IO.Redist, System.Buffers, System.Memory, System.Numerics.Vectors, System.Runtime.CompilerServices.Unsafe, System.Threading.Tasks.Extensions)
- Adds explicit version entries for System.Buffers and System.Numerics.Vectors to enable transitive pinning
- Updates binding redirects in MSBuild configuration files to match new package versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MSBuild/app.config | Updates assembly binding redirects for multiple system packages to latest versions |
| src/MSBuild/app.amd64.config | Updates assembly binding redirects and codeBase entries for AMD64 configuration |
| eng/Versions.props | Defines updated package versions for both source-only and regular builds |
| eng/Packages.props | Adds System.Numerics.Vectors package version entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
It would really be good to get this one in as the rest of our core-stack still suffers from msbuild not being on these latest dependencies. Anything blocking this? |
|
I don't think we're blocked--just have to do the coordinated update in VS. Getting an experimental insertion would be the first step, then fixing VS-side changes, then merge this here and port the VS fixes to the insertion branch. |
While 0457980 just got merged, some of the previously released packages had issues that got fixed with the latest release.
Also add entries for System.Buffers and System.Numerics.Vectors so that transitive pinning moves them to latest.