Skip to content

Conversation

@ViktorHofer
Copy link
Member

While 0457980 just got merged, some of the previously released packages had issues that got fixed with the latest release.

Also add entries for System.Buffers and System.Numerics.Vectors so that transitive pinning moves them to latest.

While 0457980 just got merged, some of the previously released packages had issues that got fixed with the latest release.

Also add entries for System.Buffers and System.Numerics.Vectors so that transitive pinning moves them to latest.
@ViktorHofer ViktorHofer requested a review from a team as a code owner April 1, 2025 11:09
@carlossanlop
Copy link
Contributor

Would you mind resolving the conflicts? There were things in main that were very different.

@ViktorHofer
Copy link
Member Author

The MSBuild team reverted the previous change. I'm waiting for @rainersigwald to figure out the right path forward (offline Teams chat group).

@rainersigwald rainersigwald self-assigned this Apr 2, 2025
@ViktorHofer
Copy link
Member Author

@rainersigwald as asked offline, I assume this PR will be blocked for some time until we can get the VS inbox assemblies updated?

@rainersigwald
Copy link
Member

Yes, I expect we should have window to start working on that after the internal 17.14 branch stuff, probably mid-to-late this week?

@ViktorHofer
Copy link
Member Author

@rainersigwald any update here? Can we update to the latest versions now?

@YuliiaKovalova
Copy link
Member

experimental insertion - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/649634
I am driving this effort now

Copilot AI review requested due to automatic review settings August 18, 2025 08:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates maintenance packages to their latest versions to resolve issues found in previously released packages. The update affects assembly binding redirects and package version definitions to ensure transitive dependencies are pinned to the latest stable versions.

  • Updates multiple system packages to their latest maintenance versions (Microsoft.IO.Redist, System.Buffers, System.Memory, System.Numerics.Vectors, System.Runtime.CompilerServices.Unsafe, System.Threading.Tasks.Extensions)
  • Adds explicit version entries for System.Buffers and System.Numerics.Vectors to enable transitive pinning
  • Updates binding redirects in MSBuild configuration files to match new package versions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/MSBuild/app.config Updates assembly binding redirects for multiple system packages to latest versions
src/MSBuild/app.amd64.config Updates assembly binding redirects and codeBase entries for AMD64 configuration
eng/Versions.props Defines updated package versions for both source-only and regular builds
eng/Packages.props Adds System.Numerics.Vectors package version entry

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@ViktorHofer
Copy link
Member Author

It would really be good to get this one in as the rest of our core-stack still suffers from msbuild not being on these latest dependencies. Anything blocking this?

@rainersigwald
Copy link
Member

I don't think we're blocked--just have to do the coordinated update in VS. Getting an experimental insertion would be the first step, then fixing VS-side changes, then merge this here and port the VS fixes to the insertion branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants