Remove unnecessary GC.Collect calls #11671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary GC.Collect calls to avoid excessive CPU consumption during build completion.
- Removed a direct call to GC.Collect by commenting it out in OutOfProcNode.cs
- Updated the memory usage check in BuildRequestEngine.cs to bypass the GC call on 64-bit operating systems
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Build/BackEnd/Node/OutOfProcNode.cs | Removed the GC.Collect call by commenting it out, preventing synchronous GC at build completion. |
| src/Build/BackEnd/Components/BuildRequestEngine/BuildRequestEngine.cs | Extended the condition to skip manual GC triggering on 64-bit systems. |
|
do the tests rely on some finalizer to run caused by the gc collect 🤔 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Are these "node" part of Node Reuse? If so, then it is good to clean up the memory after work is done to minimize footprint while idle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11373
Context
Builds on MSBuild nodes forcing a GC immediately after the build is done. At its worst case, this burned 3 cores for 3 seconds at a time that VS and the user think the build is done and VS is likely launching the app or user back to typing, so not really a good time to consume CPU.
Changes Made
Testing
Correctness: unit tests & exp insertion.
Perf: exp VS insertion, local measurements and perfstar does not show any noticeable impact.