Skip to content

Reduce allocations for SdkResolverService #11803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Reduce allocations for SdkResolverService #11803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ private SdkResult ResolveSdkUsingResolversWithPatternsFirst(int submissionId, Sd
resolvers = GetResolvers(
_generalResolversManifestsRegistry,
loggingContext,
sdkReferenceLocation).ToList();
sdkReferenceLocation);

if (TryResolveSdkUsingSpecifiedResolvers(
resolvers,
Expand Down Expand Up @@ -274,16 +274,14 @@ private List<SdkResolver> GetResolvers(IReadOnlyList<SdkResolverManifest> resolv
List<SdkResolver> resolvers = new List<SdkResolver>();
foreach (var resolverManifest in resolversManifests)
{
if (!_manifestToResolvers.TryGetValue(resolverManifest, out IReadOnlyList<SdkResolver> newResolvers))
IReadOnlyList<SdkResolver> newResolvers;
lock (_lockObject)
{
lock (_lockObject)
if (!_manifestToResolvers.TryGetValue(resolverManifest, out newResolvers))
{
if (!_manifestToResolvers.TryGetValue(resolverManifest, out newResolvers))
{
// Loading of the needed resolvers.
newResolvers = _sdkResolverLoader.LoadResolversFromManifest(resolverManifest, sdkReferenceLocation);
_manifestToResolvers[resolverManifest] = newResolvers;
}
// Loading of the needed resolvers.
newResolvers = _sdkResolverLoader.LoadResolversFromManifest(resolverManifest, sdkReferenceLocation);
_manifestToResolvers[resolverManifest] = newResolvers;
}
}

Expand Down