Reduce allocations in TaskExecutionHost #11804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces memory allocations in TaskExecutionHost by optimizing how task item metadata is enumerated and escaped.
- Introduces specialized logic for handling CopyOnWriteDictionary and Dictionary types in metadata enumeration.
- Adds a new local function to yield escaped key-value pairs with minimal allocations.
I think this parenthesis was deleted by error. If it was a different one, more thorough look will be needed
SimaTian
reviewed
May 9, 2025
| @@ -1423,9 +1424,26 @@ private void GatherTaskItemOutputs(bool outputTargetIsItem, string outputTargetN | |||
|
|
|||
| static IEnumerable<KeyValuePair<string, string>> EnumerateMetadata(IDictionary customMetadata) | |||
| { | |||
| foreach (DictionaryEntry de in customMetadata) | |||
There was a problem hiding this comment.
What is the penalty for using the interface here please? Is it boxing in this case or something else?
(e.g. from what I read, we use specialized iterations based on type, so I assume there is something to be gained, hence the boxing question)
There was a problem hiding this comment.
The goal here is to avoid boxing the struct enumerator of these collections. In sufficiently hot paths, the allocations can really add up.
SimaTian
approved these changes
May 9, 2025
JanProvaznik
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes