Skip to content

Add struct enumerator for CopyOnWritePropertyDictionary #11806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Erarndt
Copy link
Contributor

@Erarndt Erarndt commented May 7, 2025

Fixes #

Context

Changes Made

Testing

Notes

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 22:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a new struct enumerator for the CopyOnWritePropertyDictionary to provide a custom enumeration over its property values. Key changes include:

  • Changing the public GetEnumerator() implementation to return an ImmutableDictionary enumerator.
  • Introducing explicit interface implementations for both IEnumerable and IEnumerable.
  • Adding a new Enumerator struct that provides custom iteration over the dictionary’s values.

Copy link
Member

@SimaTian SimaTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, LGTM

Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@SimaTian SimaTian merged commit dccca23 into dotnet:main May 12, 2025
10 checks passed
@Erarndt Erarndt deleted the dev/erarndt/CopyOnWritePropertyDictionary branch May 13, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants