Nullable annotate ResourceUtilities #11818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a few other things that fell out while I was doing so.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates multiple components to use nullable annotations for improved null safety.
- Updated method signatures in ResourceUtilities to accept and return nullable types.
- Modified LoggerException and BuildExceptionBase constructors and state initialization for nullability.
- Adjusted TerminalLogger to reflect the updated nullable annotations in resource formatting.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Shared/ResourceUtilities.cs | Nullable annotations have been applied to various resource methods. |
| src/Framework/LoggerException.cs | Exception constructors and custom state handling have been updated to use nullable types. |
| src/Framework/BuildException/BuildExceptionBase.cs | Constructor parameter types now allow null values. |
| src/Build/Logging/TerminalLogger/TerminalLogger.cs | Logger formatting call updated to use nullable error code and help keyword. |
surayya-MS
approved these changes
May 12, 2025
YuliiaKovalova
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a few other things that fell out while I was doing so.