Skip to content

Fix embedded resources missing in PublishAot + NoBuild binaries #12791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+77 −1
Draft

Fix embedded resources missing in PublishAot + NoBuild binaries #12791

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e968c2e
Initial plan
Copilot Nov 19, 2025
8f22852
Fix PublishAot + NoBuild embedded resources issue
Copilot Nov 19, 2025
f61713e
Refactor: Make _GenerateCompileInputs always run instead of duplicati…
Copilot Dec 19, 2025
33d17a9
Fix: Use CallTarget to ensure _GenerateCompileInputs runs in NoBuild …
Copilot Dec 19, 2025
11f3824
dependency
JanProvaznik Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3846,7 +3846,25 @@ Copyright (C) Microsoft Corporation. All rights reserved.
contribute to incremental build inconsistencies.
============================================================
-->
<Target Name="_GenerateCompileDependencyCache" Condition="'$(DesignTimeBuild)' != 'true' and '$(BuildingProject)' == 'true'" DependsOnTargets="ResolveAssemblyReferences;_GenerateCompileInputs">
<Target Name="_GenerateCompileDependencyCache" Condition="'$(DesignTimeBuild)' != 'true' and '$(BuildingProject)' == 'true'" DependsOnTargets="ResolveAssemblyReferences;PrepareResources;_GenerateCompileInputs">

<!-- If _GenerateCompileInputs was skipped and _CoreCompileResourceInputs is empty, populate it here.
This handles the NoBuild publish scenario where _GenerateCompileInputs runs once but its items
are not available when CoreCompile needs them later. PrepareResources dependency ensures that
resource metadata (OutputResource) is set before we populate the items. -->
<ItemGroup Condition="'@(_CoreCompileResourceInputs)' == ''">
<_CoreCompileResourceInputs Include="@(EmbeddedResource->'%(OutputResource)')" Condition="'%(EmbeddedResource.WithCulture)' == 'false' and '%(EmbeddedResource.Type)' == 'Resx'" />
<_CoreCompileResourceInputs Include="@(EmbeddedResource)" Condition="'%(EmbeddedResource.WithCulture)' == 'false' and '%(EmbeddedResource.Type)' == 'Non-Resx' " />
<_CoreCompileResourceInputs Include="@(ManifestResourceWithNoCulture)" Condition="'%(ManifestResourceWithNoCulture.EmittedForCompatibilityOnly)'==''">
<Type>Resx</Type>
<WithCulture>false</WithCulture>
</_CoreCompileResourceInputs>
<_CoreCompileResourceInputs Include="@(ManifestNonResxWithNoCultureOnDisk)" Condition="'%(ManifestNonResxWithNoCultureOnDisk.EmittedForCompatibilityOnly)'==''">
<Type>Non-Resx</Type>
<WithCulture>false</WithCulture>
</_CoreCompileResourceInputs>
</ItemGroup>
Copy link
Member

@JanProvaznik JanProvaznik Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this is poorly maintainable adding a lot of code for a specific scenario, can it be done cleaner?

Copy link
Contributor Author

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Refactored in f61713e to make _GenerateCompileInputs always run (via Outputs="") and clear items before repopulating. This eliminates the code duplication and keeps a single source of truth for the resource input logic.


<ItemGroup>
<CustomAdditionalCompileInputs Include="$(IntermediateOutputPath)$(MSBuildProjectFile).CoreCompileInputs.cache" />
<CoreCompileCache Include="@(Compile)" />
Expand Down