Skip to content

Fix embedded resources missing in PublishAot + NoBuild binaries #12791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+77 −1
Draft

Fix embedded resources missing in PublishAot + NoBuild binaries #12791

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e968c2e
Initial plan
Copilot Nov 19, 2025
8f22852
Fix PublishAot + NoBuild embedded resources issue
Copilot Nov 19, 2025
f61713e
Refactor: Make _GenerateCompileInputs always run instead of duplicati…
Copilot Dec 19, 2025
33d17a9
Fix: Use CallTarget to ensure _GenerateCompileInputs runs in NoBuild …
Copilot Dec 19, 2025
11f3824
dependency
JanProvaznik Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Tasks/Microsoft.Common.CurrentVersion.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3663,7 +3663,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
Create the _CoreCompileResourceInputs list of inputs to the CoreCompile target.
============================================================
-->
<Target Name="_GenerateCompileInputs">
<Target Name="_GenerateCompileInputs" Outputs="">

<MSBuildInternalMessage
Condition="'@(ManifestResourceWithNoCulture)'!='' and '%(ManifestResourceWithNoCulture.EmittedForCompatibilityOnly)'==''"
Expand All @@ -3677,6 +3677,8 @@ Copyright (C) Microsoft Corporation. All rights reserved.
FormatArguments="MSB9005;ManifestNonResxWithNoCultureOnDisk;false;Non-Resx" />

<ItemGroup>
<!-- Clear any existing items to avoid duplicates when target runs multiple times -->
<_CoreCompileResourceInputs Remove="@(_CoreCompileResourceInputs)" />

<!-- _CoreCompileResourceInputs is the list of TLDA inputs that should trigger CoreCompile, and are listed as inputs to that target -->
<_CoreCompileResourceInputs Include="@(EmbeddedResource->'%(OutputResource)')" Condition="'%(EmbeddedResource.WithCulture)' == 'false' and '%(EmbeddedResource.Type)' == 'Resx'" />
Expand Down Expand Up @@ -3846,7 +3848,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
contribute to incremental build inconsistencies.
============================================================
-->
<Target Name="_GenerateCompileDependencyCache" Condition="'$(DesignTimeBuild)' != 'true' and '$(BuildingProject)' == 'true'" DependsOnTargets="ResolveAssemblyReferences;_GenerateCompileInputs">
<Target Name="_GenerateCompileDependencyCache" Condition="'$(DesignTimeBuild)' != 'true' and '$(BuildingProject)' == 'true'" DependsOnTargets="ResolveAssemblyReferences;PrepareResources;_GenerateCompileInputs">
<ItemGroup>
<CustomAdditionalCompileInputs Include="$(IntermediateOutputPath)$(MSBuildProjectFile).CoreCompileInputs.cache" />
<CoreCompileCache Include="@(Compile)" />
Expand Down
Loading