Migrate file I/O tasks to multithreadable task API

src/Tasks.UnitTests/Delete_Tests.cs

@@ -24,6 +24,7 @@ public sealed class Delete_Tests
         public void AttributeForwarding()
         {
             Delete t = new Delete();
+            t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
 
             ITaskItem i = new TaskItem("MyFiles.nonexistent");
             i.SetMetadata("Locale", "en-GB");
@@ -59,6 +60,7 @@ public void DeleteWithRetries()
 
                 var t = new Delete
                 {
+                    TaskEnvironment = TaskEnvironmentHelper.CreateForTest(),
                     RetryDelayMilliseconds = 1,  // speed up tests!
                     BuildEngine = new MockEngine(),
                     Files = sourceFiles,
@@ -75,6 +77,7 @@ public void DeleteWithRetries()
                 ITaskItem[] duplicateSourceFiles = { sourceItem, sourceItem };
                 t = new Delete
                 {
+                    TaskEnvironment = TaskEnvironmentHelper.CreateForTest(),
                     RetryDelayMilliseconds = 1,  // speed up tests!
                     BuildEngine = new MockEngine(),
                     Files = duplicateSourceFiles,

src/Tasks.UnitTests/FileStateTests.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.IO;
+using Microsoft.Build.Framework;
 using Microsoft.Build.Shared;
 using Microsoft.Build.Tasks;
 using Xunit;
@@ -21,25 +22,25 @@ public void BadNoName()
         {
             Assert.Throws<ArgumentException>(() =>
             {
-                new FileState("");
+                new FileState("", TaskEnvironmentHelper.CreateForTest());
             });
         }
         [Fact]
         public void BadCharsCtorOK()
         {
-            new FileState("|");
+            new FileState("|", TaskEnvironmentHelper.CreateForTest());
         }
 
         [Fact]
         public void BadTooLongCtorOK()
         {
-            new FileState(new String('x', 5000));
+            new FileState(new String('x', 5000), TaskEnvironmentHelper.CreateForTest());
         }
 
         [WindowsFullFrameworkOnlyFact(additionalMessage: ".NET Core 2.1+ no longer validates paths: https://github.com/dotnet/corefx/issues/27779#issuecomment-371253486. On Unix there is no invalid file name characters.")]
         public void BadChars()
         {
-            var state = new FileState("|");
+            var state = new FileState("|", TaskEnvironmentHelper.CreateForTest());
             Assert.Throws<ArgumentException>(() => { var time = state.LastWriteTime; });
         }
 
@@ -48,7 +49,7 @@ public void BadTooLongLastWriteTime()
         {
             Helpers.VerifyAssertThrowsSameWay(
                 delegate () { var x = new FileInfo(new String('x', 5000)).LastWriteTime; },
-                delegate () { var x = new FileState(new String('x', 5000)).LastWriteTime; });
+                delegate () { var x = new FileState(new String('x', 5000), TaskEnvironmentHelper.CreateForTest()).LastWriteTime; });
         }
 
         [Fact]
@@ -60,7 +61,7 @@ public void Exists()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.Exists, state.FileExists);
             }
@@ -79,7 +80,7 @@ public void Name()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.FullName, state.Name);
             }
@@ -92,7 +93,7 @@ public void Name()
         [Fact]
         public void IsDirectoryTrue()
         {
-            var state = new FileState(Path.GetTempPath());
+            var state = new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest());
 
             Assert.True(state.IsDirectory);
         }
@@ -106,7 +107,7 @@ public void LastWriteTime()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.LastWriteTime, state.LastWriteTime);
             }
@@ -125,7 +126,7 @@ public void LastWriteTimeUtc()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.LastWriteTimeUtc, state.LastWriteTimeUtcFast);
             }
@@ -144,7 +145,7 @@ public void Length()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.Length, state.Length);
             }
@@ -163,7 +164,7 @@ public void ReadOnly()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                FileState state = new FileState(file, TaskEnvironmentHelper.CreateForTest());
 
                 Assert.Equal(info.IsReadOnly, state.IsReadOnly);
             }
@@ -182,12 +183,13 @@ public void ExistsReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.Exists, state.FileExists);
                 File.Delete(file);
                 Assert.True(state.FileExists);
-                state.Reset();
+                state.Reset(taskEnvironment);
                 Assert.False(state.FileExists);
             }
             finally
@@ -208,15 +210,16 @@ public void NameReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.FullName, state.Name);
                 string originalName = info.FullName;
                 string oldFile = file;
                 file = oldFile + "2";
                 File.Move(oldFile, file);
                 Assert.Equal(originalName, state.Name);
-                state.Reset();
+                state.Reset(taskEnvironment);
                 Assert.Equal(originalName, state.Name); // Name is from the constructor, didn't change
             }
             finally
@@ -234,15 +237,16 @@ public void LastWriteTimeReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.LastWriteTime, state.LastWriteTime);
 
                 var time = new DateTime(2111, 1, 1);
                 info.LastWriteTime = time;
 
                 Assert.NotEqual(time, state.LastWriteTime);
-                state.Reset();
+                state.Reset(taskEnvironment);
                 Assert.Equal(time, state.LastWriteTime);
             }
             finally
@@ -260,15 +264,16 @@ public void LastWriteTimeUtcReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.LastWriteTimeUtc, state.LastWriteTimeUtcFast);
 
                 var time = new DateTime(2111, 1, 1);
                 info.LastWriteTime = time;
 
                 Assert.NotEqual(time.ToUniversalTime(), state.LastWriteTimeUtcFast);
-                state.Reset();
+                state.Reset(taskEnvironment);
                 Assert.Equal(time.ToUniversalTime(), state.LastWriteTimeUtcFast);
             }
             finally
@@ -288,13 +293,14 @@ public void LengthReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.Length, state.Length);
                 File.WriteAllText(file, "x");
 
                 Assert.Equal(info.Length, state.Length);
-                state.Reset();
+                state.Reset(taskEnvironment);
                 info.Refresh();
                 Assert.Equal(info.Length, state.Length);
             }
@@ -313,11 +319,12 @@ public void ReadOnlyReset()
             {
                 file = FileUtilities.GetTemporaryFile();
                 FileInfo info = new FileInfo(file);
-                FileState state = new FileState(file);
+                TaskEnvironment taskEnvironment = TaskEnvironmentHelper.CreateForTest();
+                FileState state = new FileState(file, taskEnvironment);
 
                 Assert.Equal(info.IsReadOnly, state.IsReadOnly);
                 info.IsReadOnly = !info.IsReadOnly;
-                state.Reset();
+                state.Reset(taskEnvironment);
                 Assert.True(state.IsReadOnly);
             }
             finally
@@ -330,32 +337,32 @@ public void ReadOnlyReset()
         [Fact]
         public void ExistsButDirectory()
         {
-            Assert.Equal(new FileInfo(Path.GetTempPath()).Exists, new FileState(Path.GetTempPath()).FileExists);
-            Assert.True(new FileState(Path.GetTempPath()).IsDirectory);
+            Assert.Equal(new FileInfo(Path.GetTempPath()).Exists, new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).FileExists);
+            Assert.True(new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).IsDirectory);
         }
 
         [Fact]
         public void ReadOnlyOnDirectory()
         {
-            Assert.Equal(new FileInfo(Path.GetTempPath()).IsReadOnly, new FileState(Path.GetTempPath()).IsReadOnly);
+            Assert.Equal(new FileInfo(Path.GetTempPath()).IsReadOnly, new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).IsReadOnly);
         }
 
         [Fact]
         public void LastWriteTimeOnDirectory()
         {
-            Assert.Equal(new FileInfo(Path.GetTempPath()).LastWriteTime, new FileState(Path.GetTempPath()).LastWriteTime);
+            Assert.Equal(new FileInfo(Path.GetTempPath()).LastWriteTime, new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).LastWriteTime);
         }
 
         [Fact]
         public void LastWriteTimeUtcOnDirectory()
         {
-            Assert.Equal(new FileInfo(Path.GetTempPath()).LastWriteTimeUtc, new FileState(Path.GetTempPath()).LastWriteTimeUtcFast);
+            Assert.Equal(new FileInfo(Path.GetTempPath()).LastWriteTimeUtc, new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).LastWriteTimeUtcFast);
         }
 
         [Fact]
         public void LengthOnDirectory()
         {
-            Helpers.VerifyAssertThrowsSameWay(delegate () { var x = new FileInfo(Path.GetTempPath()).Length; }, delegate () { var x = new FileState(Path.GetTempPath()).Length; });
+            Helpers.VerifyAssertThrowsSameWay(delegate () { var x = new FileInfo(Path.GetTempPath()).Length; }, delegate () { var x = new FileState(Path.GetTempPath(), TaskEnvironmentHelper.CreateForTest()).Length; });
         }
 
         [Fact]
@@ -365,7 +372,7 @@ public void DoesNotExistLastWriteTime()
         {
             string file = Guid.NewGuid().ToString("N");
 
-            Assert.Equal(new FileInfo(file).LastWriteTime, new FileState(file).LastWriteTime);
+            Assert.Equal(new FileInfo(file).LastWriteTime, new FileState(file, TaskEnvironmentHelper.CreateForTest()).LastWriteTime);
         }
 
         [Fact]
@@ -375,15 +382,15 @@ public void DoesNotExistLastWriteTimeUtc()
         {
             string file = Guid.NewGuid().ToString("N");
 
-            Assert.Equal(new FileInfo(file).LastWriteTimeUtc, new FileState(file).LastWriteTimeUtcFast);
+            Assert.Equal(new FileInfo(file).LastWriteTimeUtc, new FileState(file, TaskEnvironmentHelper.CreateForTest()).LastWriteTimeUtcFast);
         }
 
         [Fact]
         public void DoesNotExistLength()
         {
             string file = Guid.NewGuid().ToString("N"); // presumably doesn't exist
 
-            Helpers.VerifyAssertThrowsSameWay(delegate () { var x = new FileInfo(file).Length; }, delegate () { var x = new FileState(file).Length; });
+            Helpers.VerifyAssertThrowsSameWay(delegate () { var x = new FileInfo(file).Length; }, delegate () { var x = new FileState(file, TaskEnvironmentHelper.CreateForTest()).Length; });
         }
 
         [Fact]
@@ -393,24 +400,24 @@ public void DoesNotExistIsDirectory()
             {
                 string file = Guid.NewGuid().ToString("N"); // presumably doesn't exist
 
-                var x = new FileState(file).IsDirectory;
+                var x = new FileState(file, TaskEnvironmentHelper.CreateForTest()).IsDirectory;
             });
         }
         [Fact]
         public void DoesNotExistDirectoryOrFileExists()
         {
             string file = Guid.NewGuid().ToString("N"); // presumably doesn't exist
 
-            Assert.Equal(Directory.Exists(file), new FileState(file).DirectoryExists);
+            Assert.Equal(Directory.Exists(file), new FileState(file, TaskEnvironmentHelper.CreateForTest()).DirectoryExists);
         }
 
         [Fact]
         public void DoesNotExistParentFolderNotFound()
         {
             string file = Guid.NewGuid().ToString("N") + "\\x"; // presumably doesn't exist
 
-            Assert.False(new FileState(file).FileExists);
-            Assert.False(new FileState(file).DirectoryExists);
+            Assert.False(new FileState(file, TaskEnvironmentHelper.CreateForTest()).FileExists);
+            Assert.False(new FileState(file, TaskEnvironmentHelper.CreateForTest()).DirectoryExists);
         }
     }
 }

src/Tasks.UnitTests/MakeDir_Tests.cs

@@ -29,6 +29,7 @@ public void AttributeForwarding()
                 MakeDir t = new MakeDir();
                 MockEngine engine = new MockEngine();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
 
                 t.Directories = new ITaskItem[]
                 {
@@ -76,6 +77,7 @@ public void SomeInputsFailToCreate()
                 MakeDir t = new MakeDir();
                 MockEngine engine = new MockEngine();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
 
                 t.Directories = new ITaskItem[]
                 {
@@ -133,6 +135,7 @@ public void CreateNewDirectory()
                 MakeDir t = new MakeDir();
                 MockEngine engine = new MockEngine();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
 
                 t.Directories = new ITaskItem[]
                 {
@@ -183,6 +186,7 @@ public void QuestionCreateNewDirectory()
                 MakeDir t = new MakeDir();
                 MockEngine engine = new MockEngine();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
                 t.FailIfNotIncremental = true;
                 t.Directories = dirList;
 
@@ -199,6 +203,7 @@ public void QuestionCreateNewDirectory()
                 engine.Log = "";
                 t = new MakeDir();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
                 t.Directories = dirList;
                 success = t.Execute();
                 Assert.True(success);
@@ -241,6 +246,7 @@ public void FileAlreadyExists()
                 MakeDir t = new MakeDir();
                 MockEngine engine = new MockEngine();
                 t.BuildEngine = engine;
+                t.TaskEnvironment = TaskEnvironmentHelper.CreateForTest();
 
                 t.Directories = new ITaskItem[]
                 {