Fill holes in BuildEventContext construction and evaluation ID propagation#12946

Open

baronfel wants to merge 24 commits intomainfrom

unify-buildeventcontext-id-tracking

Commits on Jan 5, 2026

Try to prevent direct creation of buildeventcontexts so we can control id propagation
baronfel
committed
Convert all other callsites to use the builder API
baronfel
committed
update compat baselines - we'll likely need to revert this, but this is an accounting of what's changed and enables the rest of the build to occur
baronfel
committed
Make the context type a ref struct builder for perf
baronfel
committed
remove useless tests
baronfel
committed
Resolve review comments about readonly/etc.
baronfel
committed
Try to stash project evaluation Ids so that we don't lose them for tracking purposes when project configurations are temporarily cached.
baronfel
committed
Fix this spot too
baronfel
committed
try to rely only on cached data for eval ids
baronfel
committed
Add serialization of evaluation id to projectstarted event translation in a version-compatible way
baronfel
committed
use safer accessor for project evaluation id for buildrequestconfigurations
baronfel
committed
Correct some auto-migrated callsite chains so that test invariants are preserved
baronfel
committed
Fix a few more missed expectations
baronfel
committed
Reduce the direct use of CreateInitial in favor of flowing contexts through the system more directly
baronfel
committed
Another refactoring to reduce direct usage of CreateInitial and flow more contexts
baronfel
committed
Make submissions track their own build event context
baronfel
committed
Make it possible to send projectstarted events that represent the node the project lived on when sending cached results
baronfel
committed
Transfer evaluation ids across nodes too!
baronfel
committed
Try to make explicit pathways for cached and non-cached project start flows
baronfel
committed
update callsites for use-case-specific constructors
baronfel
committed
Fix some subtle invariants around needing new projectContextIds, especially for cached project contexts
baronfel
committed
Remove test that is meaningless due to API forcing good pathways
baronfel
committed
fix assert to check the correct invariant
baronfel
committed

Commits on Jan 8, 2026

Fix incorrect node context creation - we correctly only ever log the cache-based projectstarted messages from the scheduler node. Before we were incorrectly saying they came from the remote node.
baronfel
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fill holes in BuildEventContext construction and evaluation ID propagation#12946

Fill holes in BuildEventContext construction and evaluation ID propagation#12946
baronfel wants to merge 24 commits intomainfrom
unify-buildeventcontext-id-tracking

Commits on Jan 5, 2026

Try to prevent direct creation of buildeventcontexts so we can control id propagation

Convert all other callsites to use the builder API

update compat baselines - we'll likely need to revert this, but this is an accounting of what's changed and enables the rest of the build to occur

Make the context type a ref struct builder for perf

remove useless tests

Resolve review comments about readonly/etc.

Try to stash project evaluation Ids so that we don't lose them for tracking purposes when project configurations are temporarily cached.

Fix this spot too

try to rely only on cached data for eval ids

Add serialization of evaluation id to projectstarted event translation in a version-compatible way

use safer accessor for project evaluation id for buildrequestconfigurations

Correct some auto-migrated callsite chains so that test invariants are preserved

Fix a few more missed expectations

Reduce the direct use of CreateInitial in favor of flowing contexts through the system more directly

Another refactoring to reduce direct usage of CreateInitial and flow more contexts

Make submissions track their own build event context

Make it possible to send projectstarted events that represent the node the project lived on when sending cached results

Transfer evaluation ids across nodes too!

Try to make explicit pathways for cached and non-cached project start flows

update callsites for use-case-specific constructors

Fix some subtle invariants around needing new projectContextIds, especially for cached project contexts

Remove test that is meaningless due to API forcing good pathways

fix assert to check the correct invariant

Commits on Jan 8, 2026

Fix incorrect node context creation - we correctly only ever log the cache-based projectstarted messages from the scheduler node. Before we were incorrectly saying they came from the remote node.