Decouple SidecarTaskHostNode from OutOfProcTaskHostNode #13145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created OutOfProcTaskHostNodeBase as abstract base class with shared functionality - OutOfProcTaskHostNode: Regular taskhost with stub IBuildEngine callbacks (unchanged behavior) - SidecarTaskHostNode: Sidecar taskhost that will support callback forwarding to parent - XMake.cs: Factory pattern to instantiate correct node type based on nodeReuse flag This separates the concerns so that callback infrastructure is only in SidecarTaskHostNode, keeping the regular taskhost simple and avoiding the back-and-forth IPC overhead when not needed.
- Regular TaskHost uses /nodemode:2 (OutOfProcTaskHostNode) - Sidecar TaskHost uses /nodemode:4 (SidecarTaskHostNode) when nodeReuse is enabled - Update NodeProviderOutOfProcTaskHost to select nodemode based on nodeReuse - Update DebugUtils to recognize nodemode:4 as SidecarTaskHostNode - Update IsInTaskHostNode() to include both node types
JanProvaznik
force-pushed
the
callbacksdecouple
branch
from
a8d3b7b to
0f2f2cd
Compare
Member
Author
|
meeting outcome: this is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decouples the Sidecar TaskHost from the regular TaskHost to separate concerns:
Changes
Node Modes
Related
Prepares infrastructure for #12991 (IBuildEngine callback forwarding in taskhosts)
Testing