Fix hardcoded path separators in output paths#13222
Open
Serajfard wants to merge 2 commits intodotnet:mainfrom
Open
Fix hardcoded path separators in output paths#13222Serajfard wants to merge 2 commits intodotnet:mainfrom
Serajfard wants to merge 2 commits intodotnet:mainfrom
Conversation
Author
|
@dotnet-policy-service agree |
…nt path formatting
Member
|
MSBuild generally handles backslashes in path descriptions fine, by correcting them "just in time". I would like to dig into exactly what is going wrong, since these changes shouldn't be required and dramatically reduce readability. Can you open an issue with repro steps that create one of the paths with literal backslashes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.Common.CurrentVersion.targetshardcodes Windows path separators (\) when computingBaseOutputPath,OutputPath,BaseIntermediateOutputPath, andIntermediateOutputPath.On Unix-based systems,
\is a valid filename character, not a path separator. This causes MSBuild to create literal directories such asbin\Debug, which are not ignored by standard.gitignorerules and can later break MSBuild path enumeration, globbing, and builds.This issue is especially visible during design-time builds (e.g.
dotnet ef migrations add) but can affect any build on non-Windows platforms.