Support non sdk projects in tf compat check #3620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, ProjectReferences to non-SDK projects did not report a `TargetFrameworks` list to the referencing project because prior to the .NET Core SDK, the TFM for a project was defined in `$(TargetFrameworkMoniker)` as the long form of the moniker. Fixes dotnet#3546 by falling back to the legacy TFM in the included-in-all- projects copy of `GetTargetFrameworks`.
Contributor
|
Let's re-target this one to master and let CI run on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3550 got accidentally closed and won't let me reopen.