Revert "Reverted and rebuilt for localizable strings. (#5246)" #5276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d306cc.
Member
|
Can you please combine with #5207? |
Contributor
Author
|
I'd already merged it in. This PR is an intermediate stepping point in case you wanted to merge them separately, but #5207 was already updated with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5d306cc.
This reverts #5246.
That PR removed an error message that appeared whenever a task returned false (failed) without logging an error. Although desirable for debugging behavior, multiple edge cases appeared after it was merged. Some of those were resolved with #5173 and #5191, but with #5203, we decided to back this out until 16.7. The remaining problems should be fixed with #5207.
This resolves #2036.