-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional reflection invoke benchmarks #4588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it's ok to have those repeated couple of variables be part of the test themselves instead of taken outside during the warmup stage.
/ba-g F# failure but issues were created but not picking up with Build Analysis plus other PRs have same errors |
@DrewScoggins @adamsitnik what is missing to allow Merge here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Add benchmarks for the MethodInvoker and ConstructorInvoker classes and for an additional case of re-invoking the constructor on an existing object.
These will help verify upcoming changes with startup performance optimizations.
FWIW here's my local results