-
Notifications
You must be signed in to change notification settings - Fork 285
Update MAUI iOS samples to .NET 11 workloads and add CoreCLR interpreter support #5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 33 commits
2954a33
b1da2d7
06ae6b0
1a30450
980ff4b
b9f4bdc
7ffbbb7
e138be4
c168ce3
820b784
553baf2
3d304ab
9776ccf
2aedb16
515e18b
8237193
d23f051
86a96fd
a52dea8
e0701c5
a9916f2
4ece98e
5518867
dc36def
112cf7a
bb4508b
f43963c
a033c20
c9b515e
fd65821
dcfbcf0
206ef41
b8775d1
2cf22ef
545702b
6444b55
6e7b6e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1010,9 +1010,10 @@ def publish_dotnet_app_to_payload(payload_dir_name: str, csproj_path: str, self_ | |
|
|
||
| # TODO: See if these commands are needed for linux as they were being called before but were failing. | ||
| if args.os_group == "windows" or args.os_group == "osx": | ||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "--upgrade", "pip"]).run() | ||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "urllib3==1.26.19"]).run() | ||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", "--user", "requests"]).run() | ||
| break_system_packages = ["--break-system-packages"] if args.os_group == "osx" else [] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To double check, the new
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it fixes the failures in #5054
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason why we don't create a python environment (
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like we should be using a venv looking at the logs from the runs, so maybe there is just a different interaction on OSX that causes the error to still show up despite being in a venv. Here is part of the installing prereqs near the top of job from the test run:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks Parker. Looking at the log, this seems to be coming from the helix machine but the commands above are run on the macOS build image where I don't see |
||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "--upgrade", "pip"]).run() | ||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "urllib3==1.26.19"]).run() | ||
| RunCommand([*(agent_python.split(" ")), "-m", "pip", "install", *break_system_packages, "--user", "requests"]).run() | ||
|
|
||
| scenarios_path = os.path.join(args.performance_repo_dir, "src", "scenarios") | ||
| script_path = os.path.join(args.performance_repo_dir, "scripts") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.