Upgrade to net9

[ryzngard]

This will be needed for the new EA so putting in a separate PR

[davidwengier]

I'm guessing this comment is not an issue any more? https://github.com/dotnet/razor/pull/11000/files#r1796869549

[ryzngard]

I'm guessing this comment is not an issue any more? https://github.com/dotnet/razor/pull/11000/files#r1796869549

Hmm I'll take a look. From vs code side everything should be fine. I don't know why this would be a problem in vs but I'll kick off integration tests and a test insertion

[davidwengier]

I know nothing about nothing, I was just mainly interested in how many more changes there are in @jjonescz's PR, but it is relatively old, so I wouldn't be surprised if it was working around things that now no longer need to be worked around.

[jjonescz]

VSCode might have been at net8.0 at the time and is not now? But I don't know how shipping razor there works, perhaps it was never a problem. Other parts/workarounds from my PR were extracted into separate PRs (#11005, #11006), so that's why they shouldn't be needed anymore.

[ryzngard]

https://dev.azure.com/dnceng/internal/_build/results?buildId=2649815&view=results for test insertion

[ryzngard]

VSCode might have been at net8.0 at the time and is not now?

It probably would have been okay to upgrade but if we let Roslyn do it first then we avoid some work ;) We're roll forward so we're technically running net9 even if we target net8. The extension handles downloading the runtime as needed

[DustinCampbell]

Consider copying the approach taken in https://github.com/dotnet/roslyn/blob/b6ed7a5f13a3f00e7edf8cc4fab0d4524251f056/eng/targets/TargetFrameworks.props#L14-L22 even more. I.e., instead of setting these in the <Otherwise> block, declare and set them in the main <PropertyGroup> above and like the <Choose> just override them. That way, they're easy to update.

Also, consider renaming DefaultNetFxTargetFramework, since you're unifying the naming convention.

[ryzngard]

Consider copying the approach taken in dotnet/roslyn@b6ed7a5/eng/targets/TargetFrameworks.props#L14-L22 even more. I.e., instead of setting these in the block, declare and set them in the main above and like the just override them. That way, they're easy to update.

SGTM :)

Also, consider renaming DefaultNetFxTargetFramework, since you're unifying the naming convention.

To NetFxVS?

[DustinCampbell]

To NetFxVS?

Perfect!

[DustinCampbell]

Looking good! I think your simplification/unification of TFMs can still be improved a bit more, but I'll definitely drop a checkmark. ✅

[DustinCampbell]

This is outside of the scope of your PR, but I wonder if Razor tooling still needs to compile anything with netstandard2.0? I believe we only ship net8.0 binaries in service hub.