Skip to content

Deferred tag helper lowering #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chsienki wants to merge 10 commits into
base: main
Choose a base branch
from
+6,969 −1,630
Draft

Deferred tag helper lowering #12935

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
61c632c
Add FindDescendant<T> test helper for IR tree traversal
chsienki Mar 20, 2026
40ec5db
Add deferred intermediate node types for tag helper resolution
chsienki Mar 20, 2026
75ed277
Refactor lowering phase to produce deferred tag helper nodes
chsienki Mar 20, 2026
2ea6590
Add DefaultTagHelperResolutionPhase
chsienki Mar 20, 2026
fa09091
Wire up resolution phase in the compiler pipeline
chsienki Mar 20, 2026
6aa1ce6
Update existing tests for new pipeline phase ordering
chsienki Mar 20, 2026
a095b17
Update IR baselines for deferred tag helper lowering
chsienki Mar 20, 2026
3d12c68
Add source generator regression tests for component scenarios
chsienki Mar 20, 2026
083f1fa
Fix three bugs discovered during CI validation
chsienki Mar 20, 2026
d75e6df
Fix missing source mapping for empty unquoted attribute values
chsienki Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 4 additions & 4 deletions ...piler/Microsoft.AspNetCore.Razor.Language/test/CodeGeneration/DesignTimeNodeWriterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class DesignTimeNodeWriterTest : RazorProjectEngineTestBase

protected override void ConfigureCodeDocumentProcessor(RazorCodeDocumentProcessor processor)
{
processor.ExecutePhasesThrough<IRazorIntermediateNodeLoweringPhase>();
processor.ExecutePhasesThrough<DefaultTagHelperResolutionPhase>();
}

[Fact]
Expand Down Expand Up @@ -377,7 +377,7 @@ public void WriteCSharpExpressionAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = (CSharpExpressionAttributeValueIntermediateNode)documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1];
var node = (CSharpExpressionAttributeValueIntermediateNode)FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1];

using var context = TestCodeRenderingContext.CreateDesignTime(source: source);

Expand Down Expand Up @@ -409,7 +409,7 @@ public void WriteCSharpCodeAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(sourceDocument);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = (CSharpCodeAttributeValueIntermediateNode)documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1];
var node = (CSharpCodeAttributeValueIntermediateNode)FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1];

using var context = TestCodeRenderingContext.CreateDesignTime(source: sourceDocument);

Expand Down Expand Up @@ -441,7 +441,7 @@ public void WriteCSharpCodeAttributeValue_WithExpression_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = (CSharpCodeAttributeValueIntermediateNode)documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1];
var node = (CSharpCodeAttributeValueIntermediateNode)FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1];

using var context = TestCodeRenderingContext.CreateDesignTime(source: source);

Expand Down
11 changes: 6 additions & 5 deletions ...Compiler/Microsoft.AspNetCore.Razor.Language/test/CodeGeneration/RuntimeNodeWriterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class RuntimeNodeWriterTest : RazorProjectEngineTestBase

protected override void ConfigureCodeDocumentProcessor(RazorCodeDocumentProcessor processor)
{
processor.ExecutePhasesThrough<IRazorIntermediateNodeLoweringPhase>();
processor.ExecutePhasesThrough<DefaultTagHelperResolutionPhase>();
}

[Fact]
Expand Down Expand Up @@ -479,7 +479,7 @@ public void WriteHtmlAttribute_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single();
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode);

using var context = TestCodeRenderingContext.CreateRuntime();

Expand Down Expand Up @@ -508,7 +508,7 @@ public void WriteHtmlAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[0] as HtmlAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[0] as HtmlAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime();

Expand All @@ -534,7 +534,7 @@ public void WriteCSharpExpressionAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1] as CSharpExpressionAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1] as CSharpExpressionAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime();

Expand Down Expand Up @@ -569,7 +569,7 @@ public void WriteCSharpCodeAttributeValue_BuffersResult()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1] as CSharpCodeAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1] as CSharpCodeAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime(source: source);

Expand Down Expand Up @@ -651,3 +651,4 @@ public override void WriteNode(CodeTarget target, CodeRenderingContext context)
}
}
}

10 changes: 6 additions & 4 deletions ...NetCore.Razor.Language/test/CodeGeneration/TagHelperHtmlAttributeRuntimeNodeWriterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Linq;
using Microsoft.AspNetCore.Razor.Language.Intermediate;
using Xunit;
Expand All @@ -13,7 +14,7 @@ public class TagHelperHtmlAttributeRuntimeNodeWriterTest : RazorProjectEngineTes

protected override void ConfigureCodeDocumentProcessor(RazorCodeDocumentProcessor processor)
{
processor.ExecutePhasesThrough<IRazorIntermediateNodeLoweringPhase>();
processor.ExecutePhasesThrough<DefaultTagHelperResolutionPhase>();
}

[Fact]
Expand All @@ -26,7 +27,7 @@ public void WriteHtmlAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[0] as HtmlAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[0] as HtmlAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime();

Expand All @@ -51,7 +52,7 @@ public void WriteCSharpExpressionAttributeValue_RendersCorrectly()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1] as CSharpExpressionAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1] as CSharpExpressionAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime();

Expand Down Expand Up @@ -85,7 +86,7 @@ public void WriteCSharpCodeAttributeValue_BuffersResult()
var codeDocument = ProjectEngine.CreateCodeDocument(source);
var processor = CreateCodeDocumentProcessor(codeDocument);
var documentNode = processor.GetDocumentNode();
var node = documentNode.Children.OfType<HtmlAttributeIntermediateNode>().Single().Children[1] as CSharpCodeAttributeValueIntermediateNode;
var node = FindDescendant<HtmlAttributeIntermediateNode>(documentNode).Children[1] as CSharpCodeAttributeValueIntermediateNode;

using var context = TestCodeRenderingContext.CreateRuntime(source: source);

Expand All @@ -112,3 +113,4 @@ public void WriteCSharpCodeAttributeValue_BuffersResult()
ignoreLineEndingDifferences: true);
}
}

2 changes: 1 addition & 1 deletion ...spNetCore.Razor.Language/test/DefaultRazorIntermediateNodeLoweringPhaseIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ protected override void ConfigureProjectEngine(RazorProjectEngineBuilder builder

protected override void ConfigureCodeDocumentProcessor(RazorCodeDocumentProcessor processor)
{
processor.ExecutePhasesThrough<IRazorIntermediateNodeLoweringPhase>();
processor.ExecutePhasesThrough<DefaultTagHelperResolutionPhase>();
}

[Fact]
Expand Down
Loading
Loading