Ix providers code generation using T4 #911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we needed the netstandard 2.1 for some of the Ix libraries as a couple methods moved to the BCL and we provide a trimmed facade for those platforms. may not be needed for all of them, but something to be aware of |
|
Ah I see; let me look into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use T4 to generate these APIs, just like we do for the asynchronous variant. Support for factories on the
IQueryProviderinterface - which is a non-standard query provider technique borrowed from Rx - is dropped for now (but is rarely used). We can reintroduce it across the board, but need to consider a few technical challenges (e.g. support ofEnumerableRewriterto target these methods).