Fix #6640 #6670
Open
Fix #6640 #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6670 +/- ##
==========================================
+ Coverage 96.32% 96.39% +0.07%
==========================================
Files 1389 1379 -10
Lines 325529 322268 -3261
Branches 10729 10460 -269
==========================================
- Hits 313579 310666 -2913
+ Misses 9237 9110 -127
+ Partials 2713 2492 -221 |
Youssef1313
reviewed
Jun 6, 2023
.../Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/OperatorOverloadsHaveNamedAlternates.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jun 19, 2023
| @@ -99,7 +99,7 @@ private static void AnalyzeSymbol(SymbolAnalysisContext symbolContext) | |||
| // don't report a diagnostic on the `op_False` method because then the user would see two diagnostics for what is really one error | |||
| // special-case looking for `IsTrue` instance property | |||
| // named properties can't be overloaded so there will only ever be 0 or 1 | |||
| IPropertySymbol property = typeSymbol.GetMembers(IsTrueText).OfType<IPropertySymbol>().FirstOrDefault(); | |||
| IPropertySymbol property = typeSymbol.GetBaseTypesAndThis().SelectMany(x => x.GetMembers(IsTrueText).OfType<IPropertySymbol>()).FirstOrDefault(); | |||
There was a problem hiding this comment.
I believe this is the case where using a loop with a break on first found match would be more efficient than linq. A local function would also work.
|
@NewellClark are you able to address the feedback and resolve the merge conflicts? Thanks! |
|
Looks like the file has changed sufficiently in main that it would be easier for me to simply reimplement this than try to merge. I'll do this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed issue #6640, and added unit tests to confirm.