Fix CA2021 false positive for generic class types #7488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7357.
#7183 changed the
CastWillAlwaysFail(ITypeSymbol castFrom, ITypeSymbol castTo)
to work withcastFrom.OriginalDefinition
/castTo.OriginalDefinition
, eliding the generic type information in order to fix issues with interfaces, but that appears to have broken the check for class types. This reverts just the class type case to use thecastFrom
/castTo
types passed in instead of the.OriginalDefinition
. I'm not sure I quite understand why that's the only place this matters, but I tried a few variations withstruct
s andinterface
s and couldn't get any other false positives.