Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use auto properties #74637

Merged
merged 11 commits into from
Aug 3, 2024
Merged

Use auto properties #74637

merged 11 commits into from
Aug 3, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Aug 2, 2024 •
edited
Loading

MOving to auto-props before #74629 goes in. To make it so we can validate just the new field functionality and check how well that works.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 2, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review August 2, 2024 20:05
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 2, 2024 20:05
dibarbet
dibarbet approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's one change I'm not a fan of

src/LanguageServer/Protocol/Handler/SemanticTokens/SemanticTokensSchema.cs Outdated Show resolved Hide resolved
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 2, 2024 21:07
@build-analysis build-analysis bot mentioned this pull request Aug 2, 2024
Open
3 tasks
@CyrusNajmabadi CyrusNajmabadi merged commit 5cbc17d into dotnet:main Aug 3, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 3, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the useAutoProp branch August 3, 2024 04:06
@chsienki chsienki mentioned this pull request Aug 5, 2024
Merged
This was referenced Aug 7, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.12 P2
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @dibarbet