Collection expressions: check conversion to ICollection<T> for spread optimization #74949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
RikkiGibson
reviewed
Aug 29, 2024
| @@ -1075,17 +1077,20 @@ private BoundExpression CreateAndPopulateList(BoundCollectionExpression node, Ty | |||
|
|
|||
| // If collection has a struct enumerator but doesn't implement ICollection<T> | |||
| // then manual `foreach` is always more efficient then using `AddRange` method | |||
| if (enumeratorInfo.GetEnumeratorInfo.Method.ReturnType.IsValueType && | |||
| !enumeratorInfo.CollectionType.ImplementsInterface(iCollectionOfElementType, ref discardedUseSiteInfo)) | |||
| if (enumeratorInfo.GetEnumeratorInfo.Method.ReturnType.IsValueType ) | |||
There was a problem hiding this comment.
Suggested change
| if (enumeratorInfo.GetEnumeratorInfo.Method.ReturnType.IsValueType ) | |
| if (enumeratorInfo.GetEnumeratorInfo.Method.ReturnType.IsValueType) |
RikkiGibson
reviewed
Aug 29, 2024
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Show resolved
Hide resolved
RikkiGibson
approved these changes
Aug 29, 2024
|
@dotnet/roslyn-compiler for a second review, thanks. |
chsienki
approved these changes
Aug 30, 2024
| @@ -1075,19 +1077,22 @@ private BoundExpression CreateAndPopulateList(BoundCollectionExpression node, Ty | |||
|
|
|||
| // If collection has a struct enumerator but doesn't implement ICollection<T> | |||
There was a problem hiding this comment.
Nit:
Suggested change
| // If collection has a struct enumerator but doesn't implement ICollection<T> | |
| // If collection has a struct enumerator but doesn't have a conversion to ICollection<T> |
There was a problem hiding this comment.
Thanks. I'll hold off changing the comment for now because changes here will conflict with another PR in progress, and since I believe the existing comment captures the intent. We can update later if needed.
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Conversionsmethod to check forICollection<T>for spread optimization.Fixes #74894
See #74630
See #74769 (comment)