Partial events and constructors: IDE #77337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
3 tasks
|
@cston @RikkiGibson FYI |
|
@dotnet/roslyn-ide for a review, thanks |
RikkiGibson
approved these changes
Feb 25, 2025
| symbol = (symbol as IPropertySymbol)?.PartialImplementationPart ?? symbol; | ||
| symbol = symbol switch | ||
| { | ||
| IMethodSymbol method => method.PartialImplementationPart ?? method, |
There was a problem hiding this comment.
nit: it feels like the pattern itself could also just test that the PartialImplementationPart is non-null, and the _ => symbol case can be used instead of ?? method, etc. in these arms.
| return CreateResolution(result, $"({nameof(EventSymbolKey)} '{metadataName}' not found)", out failureReason); | ||
| using var events = GetMembersOfNamedType<IEventSymbol>(containingTypeResolution, metadataName); | ||
|
|
||
| if (events.Count == 1 && isPartialImplementationPart) |
There was a problem hiding this comment.
It looks like this is making use of an assumption that events are not overloaded. Is this really what we want to do when, say, erroneous duplicated partial events are present in source?
| @@ -238,6 +238,12 @@ private static bool IsPartialMethodDefinitionPart(IPropertySymbol symbol) | |||
| private static bool IsPartialMethodImplementationPart(IPropertySymbol symbol) | |||
| => symbol.PartialDefinitionPart != null; | |||
|
|
|||
| private static bool IsPartialMethodDefinitionPart(IEventSymbol symbol) | |||
There was a problem hiding this comment.
It might be good to name these according to the symbol kinds they actually deal with, i.e. IsPartialEventDefinitionPart. Not critical, though.
| Assert.NotSame(implementation, definition); | ||
|
|
||
| // Assert that both the definition and implementation resolve back to themselves | ||
| Assert.Equal(definition, ResolveSymbol(definition, comp, SymbolKeyComparison.None)); |
|
i can look at these tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #76859