Skip to content

Emit CompilerFeatureRequiredAttribute for instance operators #78163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlekseyTs
Copy link
Contributor

This prevents old compilers and other compilers (VB, etc.) from consuming the new APIs in an unintended way.

This prevents old compilers and other compilers (VB, etc.) from consuming the new APIs in an unintended way.
@AlekseyTs AlekseyTs requested review from 333fred and cston April 15, 2025 22:34
@AlekseyTs AlekseyTs requested a review from a team as a code owner April 15, 2025 22:34
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 15, 2025
@AlekseyTs
Copy link
Contributor Author

@cston, @333fred, @dotnet/roslyn-compiler Please review.

1 similar comment
@AlekseyTs
Copy link
Contributor Author

@cston, @333fred, @dotnet/roslyn-compiler Please review.

@cston
Copy link
Member

cston commented Apr 21, 2025

        var comp = CreateCompilation([source, CompilerFeatureRequiredAttribute], targetFramework: TargetFramework.Net90);

Consider not including CompilerFeatureRequiredAttribute source in at least one test that targets .NET 7 or later, so it's clear the BCL definition is sufficient. #Pending


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:162 in 50a18fd. [](commit_id = 50a18fd, deletion_comment = False)

@AlekseyTs
Copy link
Contributor Author

@333fred, @dotnet/roslyn-compiler For the second review

@AlekseyTs
Copy link
Contributor Author

        var comp = CreateCompilation([source, CompilerFeatureRequiredAttribute], targetFramework: TargetFramework.Net90);

Consider not including CompilerFeatureRequiredAttribute source in at least one test that targets .NET 7 or later, so it's clear the BCL definition is sufficient.

I will make a change like that in a different PR.


In reply to: 2818921287


Refers to: src/Compilers/CSharp/Test/Emit3/Symbols/UserDefinedCompoundAssignmentOperatorsTests.cs:162 in 50a18fd. [](commit_id = 50a18fd, deletion_comment = False)

@AlekseyTs AlekseyTs merged commit d0d2c14 into dotnet:features/UserDefinedCompoundAssignment Apr 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Feature-UserDefinedCompoundAssignmentOperators untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants