Precursor work to merge EditorFeatures.WPF into EditorFeatures. #78308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 24, 2025
| internal sealed class EditorPeekableItemFactory( | ||
| IMetadataAsSourceFileService metadataAsSourceFileService, | ||
| IGlobalOptionService globalOptions, | ||
| IThreadingContext threadingContext) : PeekableItemFactory(metadataAsSourceFileService, globalOptions, threadingContext); |
There was a problem hiding this comment.
core code merged down (as is still exported for us to use. This is just a remnant so xaml can still import this until we move them to use the coe in the ea layer.
CyrusNajmabadi
commented
Apr 24, 2025
src/EditorFeatures/Core/Microsoft.CodeAnalysis.EditorFeatures.csproj
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Apr 24, 2025
|
|
||
| namespace Microsoft.VisualStudio.LanguageServices.Xaml.Features.Peek; | ||
|
|
||
| internal interface IXamlPeekableItemFactory |
There was a problem hiding this comment.
new EA layer code for xaml to use.
|
@jasonmalinowski ptal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves everything down, except for special code we expose to Xaml to allow them to use our Peek service. This PR also adds code into their existing EA layer to do this instead.
So we can:
Precursor to #77707