Combine up to 5 providers #78316
Combine up to 5 providers #78316
Conversation
while combining more than 2 providers, the returning tuple is very confusing, chaining Left.Left.Left etc. this adds more compine overloads that returns a flat tuple
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
|
I'm using those as extensions methods |
|
@StephaneDelcroix Can you write up an API suggestion on this? I'd be willing to try to shepherd it through (no promises of course). I do find teh |
|
Please see https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for the api review process. |
| @@ -29,8 +29,20 @@ public static class IncrementalValueProviderExtensions | |||
| public static IncrementalValueProvider<ImmutableArray<TSource>> Collect<TSource>(this IncrementalValuesProvider<TSource> source) => new IncrementalValueProvider<ImmutableArray<TSource>>(new BatchNode<TSource>(source.Node), source.CatchAnalyzerExceptions); | |||
|
|
|||
| public static IncrementalValuesProvider<(TLeft Left, TRight Right)> Combine<TLeft, TRight>(this IncrementalValuesProvider<TLeft> provider1, IncrementalValueProvider<TRight> provider2) => new IncrementalValuesProvider<(TLeft, TRight)>(new CombineNode<TLeft, TRight>(provider1.Node, provider2.Node), provider1.CatchAnalyzerExceptions); | |||
|
|
|||
| public static IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)> Combine<TProvider1, TProvider2, TProvider3>(this IncrementalValuesProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3) => provider1.Combine(provider2).Combine(provider3).Select(static (t, _) => (t.Left.Left, t.Left.Right, t.Right)); | |||
There was a problem hiding this comment.
note: i'm not sure why it's TProviderN instead of like TValueNorTSourceN. Another option is to simply not name the tuple elements as they do not seem to provide much value. In other words, i'm not sure how saying t.provider1is better than justt.Item1`. So consider just making this:
public static IncrementalValuesProvider<(TSource1, TSource2, TSource3)> Combine<TSource1, TSource2, TSource3>(this IncrementalValuesProvider<TSource1> provider1, IncrementalValueProvider<TSource2> provider2, IncrementalValueProvider<TSource3> provider3) => provider1.Combine(provider2).Combine(provider3).Select(static (t, _) => (t.Left.Left, t.Left.Right, t.Right));
Note: i would do this in the API you post. We'll also look over and have a review in the near future to hammer out names/shapes, and will post the results back.
|
Moving to draft until there is an API review session for this. |
while combining more than 2 providers, the returning tuple is very confusing, chaining Left.Left.Left etc.
this adds more combine overloads that returns a flat tuple