Provide overloads for IncrementalValue[s]Provider.Combine #78316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while combining more than 2 providers, the returning tuple is very confusing, chaining Left.Left.Left etc. this adds more compine overloads that returns a flat tuple
ghost
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
|
I'm using those as extensions methods |
jaredpar
requested changes
Apr 25, 2025
|
@StephaneDelcroix Can you write up an API suggestion on this? I'd be willing to try to shepherd it through (no promises of course). I do find teh |
|
Please see https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for the api review process. |
src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs
Outdated
Show resolved
Hide resolved
|
Moving to draft until there is an API review session for this. |
dotnet-policy-service
bot
added
the
Needs API Review
StephaneDelcroix
changed the title
- fix tuple element names - add overload up to 7+rest providers
|
I have no idea what to do with the build errors... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while combining more than 2 providers, the returning tuple is very confusing, chaining Left.Left.Left etc.
this adds more combine overloads that returns a flat tuple