*** WIP: Significantly reduce FileUtilities.GetFileTimeStamp calls #78321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In draft mode until: 1) Receive input from Jason on whether this approach is reasonable 2) Get results from speedometer run on test insertion indicating this indeed helps If those both happen, will update with more information
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
commented
Apr 25, 2025
| internal VisualStudioPortableExecutableReference( | ||
| VisualStudioMetadataReferenceManager provider, | ||
| MetadataReferenceProperties properties, | ||
| string fullPath, | ||
| FileChangeTracker? fileChangeTracker) |
| { | ||
| private sealed partial class VisualStudioPortableExecutableReference | ||
| { | ||
| private class FileTimeStampProvider |
There was a problem hiding this comment.
will do in next commit
| context.FileChanged += self.OnContextFileChanged; | ||
|
|
||
| return context; | ||
| }, (watcher, this)); |
There was a problem hiding this comment.
how expensive is this? should we consider doing outside of lock?
There was a problem hiding this comment.
This is cheap (at least for the FileChangeWatcher.CreateContext implementation)
There was a problem hiding this comment.
Unless you were talking about the GetFileTimeStamp call, which can be expensive. I could be convinced to do that outside the lock and then reobtain the lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draft mode until:
If those both happen, will update with more information
Here's the data I'm looking at and hoping to improve:
Locally, I see the number of calls to FileUtilities.GetFileTimeStamp in this callstack when opening Roslyn.sln go from 64,195 to 1,511
Test insertion (commit 2): https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/631765