Extract base LanguageServerProjectLoader from LanguageServerProjectSystem #78329
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
|
||
| namespace Microsoft.CodeAnalysis.LanguageServer.HostWorkspace; | ||
|
|
||
| internal abstract class LanguageServerProjectLoader |
There was a problem hiding this comment.
I don't expect this would be an abstract type, but rather a MEF component. if nothing else, that binary log numeric suffix should probably be shared across the different users.
There was a problem hiding this comment.
Alternately we could move that shared state to a separate MEF type so that bit it shared, and that's it. I guess that'll make things simpler in terms of not having to move so much state to the ProjectToLoad type.
|
|
||
| protected readonly AsyncBatchingWorkQueue<ProjectToLoad> _projectsToLoadAndReload; | ||
|
|
||
| protected readonly ProjectSystemProjectFactory _projectFactory; |
There was a problem hiding this comment.
If it's protected then this shouldn't have a _ underscore. But that said I'd expect this to go away if this becomes a single service via MEF, and this moves to the work items being queued.
| private readonly IFileChangeWatcher _fileChangeWatcher; | ||
| private readonly IGlobalOptionService _globalOptionService; | ||
| protected readonly ILoggerFactory _loggerFactory; | ||
| protected readonly ILogger _logger; |
There was a problem hiding this comment.
Keep this private, other components can make their own. Or expect the caller to pass it down, since that way it can specify which derived type it is.
| /// <summary> | ||
| /// A single gate for code that is adding work to <see cref="_projectsToLoadAndReload" />. This is just we don't have code simultaneously trying to load and unload solutions at once. | ||
| /// </summary> | ||
| protected readonly SemaphoreSlim _gate = new SemaphoreSlim(initialCount: 1); |
There was a problem hiding this comment.
This being protected is pretty strange -- seems like there should be a method to call that keeps this and the actual queue private. That comment I don't think makes sense though, given we don't actually have any unloading happening, so maybe just delete that while you're here while laughing at me for writing it.
The first commit renames file LanguageServerProjectSystem.cs to LanguageServerProjectLoader.cs.
The second commit re-creates LanguageServerProjectSystem.cs with new content.
You may find commit-by-commit review easier.
LanguageServerProjectLoader contains most of the logic from before. LanguageServerProjectSystem contains methods specifically for opening solutions and projects.
When we do file-based programs, we will introduce a new project system type, which has a method for opening a file-based program project.
Also, we explicitly stop storing LanguageServerWorkspaceFactory, and instead pass in the specific bits from it that we were using, because eventually LanguageServerWorkspaceFactory will hold both a file-based program workspace and the pre-existing host workspace.