Skip to content

Fix ArgumentException in SeparatedSyntaxList.ReplaceSeparator to use proper message and paramName #80690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+144 −4
Open

Fix ArgumentException in SeparatedSyntaxList.ReplaceSeparator to use proper message and paramName #80690

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67676fd
Initial plan
Copilot Oct 14, 2025
b721b49
Fix ArgumentException in SeparatedSyntaxList.ReplaceSeparator with pr…
Copilot Oct 14, 2025
7d9aee6
Remove test methods as requested in review
Copilot Oct 14, 2025
c854f33
Break RawKind and Language checks into separate validations with dedi…
Copilot Oct 16, 2025
529cd8b
Remove accidental test file from commit
Copilot Oct 16, 2025
fb6733a
Remove Program.cs from .gitignore
Copilot Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Compilers/Core/Portable/Syntax/SeparatedSyntaxList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,13 +573,13 @@ public SeparatedSyntaxList<TNode> ReplaceSeparator(SyntaxToken separatorToken, S
var index = nodesWithSeps.IndexOf(separatorToken);
if (index < 0)
{
throw new ArgumentException("separatorToken");
throw new ArgumentException(CodeAnalysisResources.MissingListItem, nameof(separatorToken));
}

if (newSeparator.RawKind != nodesWithSeps[index].RawKind ||
newSeparator.Language != nodesWithSeps[index].Language)
{
throw new ArgumentException("newSeparator");
throw new ArgumentException("New separator must have the same RawKind and Language as the separator being replaced.", nameof(newSeparator));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Break this into two separate checks, and add two new resource string exception messages. One for needing to have the same RawKind and one for needing to have the same Language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Split into two separate checks with dedicated resource strings SeparatorTokenMustHaveSameRawKind and SeparatorTokenMustHaveSameLanguage in commit 0c9ca.

}

return new SeparatedSyntaxList<TNode>(nodesWithSeps.Replace(separatorToken, newSeparator));
Expand Down