-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add regression test for ParseAttributeArgumentList with invalid input (fixes #8699) #80705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/fix-nullreferenceexception-parseattributeargumentl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add regression test for ParseAttributeArgumentList with invalid input (fixes #8699) #80705
Copilot
wants to merge
10
commits into
main
from
copilot/fix-nullreferenceexception-parseattributeargumentl
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout NullReferenceException Co-authored-by: CyrusNajmabadi <[email protected]>
Co-authored-by: CyrusNajmabadi <[email protected]>
Co-authored-by: CyrusNajmabadi <[email protected]>
Copilot finished work on behalf of
CyrusNajmabadi
October 14, 2025 15:00
CyrusNajmabadi
approved these changes
Oct 14, 2025
AlekseyTs
reviewed
Oct 14, 2025
333fred
reviewed
Oct 14, 2025
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Oct 14, 2025
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a regression test to verify that
SyntaxFactory.ParseAttributeArgumentList
properly handles invalid input without throwing aNullReferenceException
.Issue
Issue #8699 reported that calling
SyntaxFactory.ParseAttributeArgumentList("somethingWithoutBrackets")
would throw aNullReferenceException
when given text without parentheses.Resolution
Testing confirms that this issue is already fixed in the current codebase. The method now properly handles invalid input by:
AttributeArgumentListSyntax
objectOpenParenToken
andCloseParenToken
Changes
Added
TestParseAttributeArgumentListWithInvalidString
test that verifies:Example
This test serves as documentation that the issue has been resolved and prevents future regression.
Original prompt
Fixes #23877
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.