[Hot Reload] Simplify StartDebuggingSession #80712
Open
+392
−578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
changed the title
tmat
commented
Oct 14, 2025
| // It's important to do this before we start watching for changes so that we have a baseline we can compare future snapshots to. | ||
| var sourceText = await documentState.GetTextAsync(cancellationToken).ConfigureAwait(false); | ||
|
|
||
| // TODO: https://github.com/dotnet/roslyn/issues/51993 |
There was a problem hiding this comment.
The issue is fixed and "stale project" handling got improved, so we do not need to check the checksums of the documents against the PDB here anymore. We only need to load the SourceText from the disk. If the checksum doesn't match the project will be tracked as "stale".
Removing the checksum checks should speed up session start in dotnet-watch.
|
@DustinCampbell ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code paths that are no longer needed and workaround for a bug that has been fixed.
Move pre-hydrating documents to HotReloadService since this is not needed for solutions opened in the IDE.
Pre-hydrate additional and analyzer config files.
Add more tests.
Remove obsolete External Access API.
Fixes #80687