Compute if a doc is generated code or not in OOP not on the host #80715
+64
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses perf issue caused by:
#80669
The problem with the original PR was that results for a navigation operation would be computed in oop, then streamed back to VS to display. But on the VS side, we'd then go try to find which was the first non-generated-code doc so we could also navigate to that. However, this ended up doing a lot of expensive work in VS (opening files, parsing, etc) to make this determination.
Fix is to move this computation to oop when we find the result, and just have the host side check a bit that is then set in OOP.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=12581012&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/679187