-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update docs for building runtime with local Roslyn #80725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RikkiGibson
wants to merge
5
commits into
main
Choose a base branch
from
dev/rigibson/update-runtime-local-build-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
commented
Oct 14, 2025
docs/contributing/Building, Debugging, and Testing on Windows.md
Outdated
Show resolved
Hide resolved
RikkiGibson
commented
Oct 14, 2025
docs/contributing/Building, Debugging, and Testing on Windows.md
Outdated
Show resolved
Hide resolved
RikkiGibson
commented
Oct 14, 2025
docs/contributing/Building, Debugging, and Testing on Windows.md
Outdated
Show resolved
Hide resolved
RikkiGibson
commented
Oct 14, 2025
docs/contributing/Building, Debugging, and Testing on Windows.md
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Oct 15, 2025
- add `<RestoreAdditionalProjectSources><PATH-TO-YOUR-ROSLYN-ENLISTMENT>\artifacts\packages\Debug\Shipping\</RestoreAdditionalProjectSources>` using the local path to your `roslyn` repo to `Directory.Build.props` | ||
- add `<UsingToolMicrosoftNetCompilers>true</UsingToolMicrosoftNetCompilers>` and `<MicrosoftNetCompilersToolsetVersion>4.1.0-dev</MicrosoftNetCompilersToolsetVersion>` with the package version you just packed (look in above artifacts folder) to `eng/Versions.props` | ||
1. Make sure that you can build the `runtime` repo as baseline (run `build.cmd libs+libs.tests`, which should be sufficient to build all C# code, installing any prerequisites if prompted to, and perhaps `git clean -xdf` and `build.cmd -restore` initially - see [runtime repo documentation](https://github.com/dotnet/runtime/blob/main/docs/workflow/README.md) for specific prerequisites and build instructions) | ||
2. `build.cmd -pack -c Release` on your `roslyn` repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the default? I thought it's useful to get the Debug
build if I don't do anything special
jcouv
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (commit 5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the docs for building the runtime with local Roslyn. Attempting to improve clarity and indicate conditions when using a release mode or debug mode compiler is more preferable. @jcouv for review.