Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for adding a native external library dependency #105045

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

carlossanlop
Copy link
Member

Contributes to #101465

General guidance with the essential steps to add or update a native external library.

Each library might have its own specific steps, we can add them later as needed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop mentioned this pull request Jul 17, 2024
18 tasks
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some guidance somewhere about when to vendor in a library vs depend on a system library (ie explaining why we vendor in zlib-ng but don't vendor in openssl).

@carlossanlop
Copy link
Member Author

We should have some guidance somewhere about when to vendor in a library vs depend on a system library (ie explaining why we vendor in zlib-ng but don't vendor in openssl).

Good point. Let me think about this.

@carlossanlop
Copy link
Member Author

Sorry for the delay here. I have addressed the last batch of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants