Skip to content

Add ObsoleteAttribute and EditorBrowsable(Never) to DynamicDependency.Condition #107104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jtschuster
Copy link
Member

Based on dotnet/linker#1231, we decided to not actually implement what this property was intended for, and the implementation only supports "DEBUG" as the configuration. In GitHub search, I only see references to Condition in linker tests.

https://github.com/dotnet/runtime/blob/main/src/tools/illink/src/linker/Linker/DynamicDependency.cs#L111-L130

@jtschuster jtschuster added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Aug 28, 2024
@jtschuster jtschuster requested review from agocke, sbomer, vitek-karas and a team August 28, 2024 18:50
@ghost
Copy link

ghost commented Aug 28, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 28, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

@terrajobst, do we need to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants