Skip to content

Complex Rune enumeration over spans of UTF-16 and UTF-8 text #111170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Complex Rune enumeration over spans of UTF-16 and UTF-8 text #111170

wants to merge 7 commits into from

Conversation

AlexRadch
Copy link
Contributor

Close #28507

AlexRadch added 5 commits June 22, 2023 20:19
@AlexRadch
Added RunePosition
5e187c0
@AlexRadch
Revert solution file
e43112a
@AlexRadch
Code review
ae28635
@AlexRadch
Merge remote-tracking branch 'remotes/upstream/main' into RunePosition
fcdb84e
@AlexRadch
RunePosition code review
8cb6671 
- Modified constructor to be `internal` and updated property assignments.
- Enhanced `Equals` and `GetHashCode` methods for readability and performance.
- Improved XML documentation for clarity and consistency with Unicode terminology.
- Updated test methods to reflect changes in `RunePosition`, removing unnecessary assertions and adding new test cases.
- Ensured enumerators correctly handle current position in Unicode data.
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025
This was referenced Jan 7, 2025
Open
Open
Open
lilinus
lilinus reviewed Jan 8, 2025
View reviewed changes
src/libraries/System.Private.CoreLib/src/System/Text/RunePosition.cs
// generally applicable; for example, enumerating scalars from UTF-8 cannot utilize
// this same trick.

int scalarValue = Rune.ReadFirstRuneFromUtf16Buffer(_remaining);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason Rune.DecodeFromUtf16 isn't used here?
From what I can see DecodeFromUtf16 will have charsConsumer = 1 for invalid sequences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rune.ReadFirstRuneFromUtf16Buffer(_remaining) is faster than Rune.DecodeFromUtf16 and is also used in SpanRuneEnumerator.

@AlexRadch
Added implementation of IEnumerator<System.Text.RunePosition> to `U…
d726970 
…tf16Enumerator` and `Utf8Enumerator` structures.
@AlexRadch AlexRadch requested a review from lilinus January 9, 2025 11:31
@build-analysis build-analysis bot mentioned this pull request Jan 9, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilinus lilinus Awaiting requested review from lilinus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API proposal: Complex Rune enumeration over spans of UTF-16 and UTF-8 text
2 participants
@AlexRadch @lilinus