Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Enable profile consistency checks throughout JIT frontend #111498

Merged
merged 23 commits into from
Jan 22, 2025
Merged

JIT: Enable profile consistency checks throughout JIT frontend #111498

merged 23 commits into from
Jan 22, 2025

Conversation

amanasifkhalid
Copy link
Member

Part of #107749.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 16, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Jan 16, 2025
Open
Open
This was referenced Jan 16, 2025
Closed
Open
@AndyAyersMS AndyAyersMS mentioned this pull request Jan 17, 2025
Merged
@AndyAyersMS
Copy link
Member

Latest diffs

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 21, 2025
Open
3 tasks
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid amanasifkhalid mentioned this pull request Jan 21, 2025
Open
41 tasks
@amanasifkhalid
Copy link
Member Author

libraries-pgo failure is #111345.

@amanasifkhalid amanasifkhalid marked this pull request as ready for review January 21, 2025 21:05
@amanasifkhalid
Copy link
Member Author

amanasifkhalid commented Jan 21, 2025 •
edited
Loading

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs. The only phase in the backend that requires profile maintenance work, as far as I know, is switch lowering. I suspect enabling consistency through it would benefit code layout only occasionally, though I can take a look in a follow-up PR.

@amanasifkhalid amanasifkhalid merged commit 9c0c3fd into dotnet:main Jan 22, 2025
109 checks passed
@amanasifkhalid amanasifkhalid deleted the profile-checks-lowering branch January 22, 2025 16:59
@LoopedBard3 LoopedBard3 mentioned this pull request Jan 28, 2025
Open
@AndyAyersMS AndyAyersMS mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanasifkhalid @AndyAyersMS