Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 24.10 image #111504

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Add Ubuntu 24.10 image #111504

merged 4 commits into from
Jan 21, 2025

Conversation

richlander
Copy link
Member

@richlander richlander commented Jan 16, 2025 •
edited
Loading

  • Tried added Debian 13 and 24.10 earlier
  • We're going to use this PR to fix the test breaks

Related:

@tarekgh

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

This was referenced Jan 16, 2025
Open
Open
@jkotas
Copy link
Member

jkotas commented Jan 17, 2025

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh
Copy link
Member

tarekgh commented Jan 17, 2025

I'll try to look at the failed time zone tests and fix them in this PR.

@tarekgh
Copy link
Member

tarekgh commented Jan 17, 2025

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Jan 17, 2025
@tarekgh
Copy link
Member

tarekgh commented Jan 18, 2025

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh
Copy link
Member

tarekgh commented Jan 19, 2025

@filipnavara @stephentoub could you please help looking at failed test https://helixr18s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-111504-merge-1928f94a14a8400bac/System.Net.Security.Unit.Tests/3/console.992e600c.log?helixlogtype=result and adjust the test as needed to unblock this PR? Thanks!

@filipnavara
Copy link
Member

filipnavara commented Jan 20, 2025 •
edited
Loading

It looks like IsNtlmAvailable returns a wrong value. I'll have to reproduce it locally... perhaps something changed in the image with regards to shipping the gss-ntlmssp package.

The image seems to have gss-ntlmssp installed, so IsNtlmAvailable should have returned true and it didn't:

Package: gss-ntlmssp
Version: 1.2.0-1build3
Status: install ok installed

filipnavara
filipnavara reviewed Jan 20, 2025
View reviewed changes
eng/pipelines/libraries/helix-queues-setup.yml
@@ -34,7 +34,7 @@ jobs:

# Linux arm64
- ${{ if eq(parameters.platform, 'linux_arm64') }}:
- (Ubuntu.2204.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-22.04-helix-arm64v8
- (Ubuntu.2410.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-24.10-helix-arm64v8
Copy link
Member

@filipnavara filipnavara Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could someone enlighten me about the naming scheme? I am bit confused about Ubuntu 24.10 still having Ubuntu.2204.ArmArch.Open in the name. (Same for the other entries.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Ubuntu 24.10 container running on Ubuntu 22.04 physical machine (ie the kernel is from Ubuntu 22.04).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comes from "fixes" we put in for #67353 @filipnavara.
Do you want to disable the test as part of this PR @richlander?
NTLM was broken on Ubuntu for a while and it seems like it is finally fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have context to make that decision. Can you elaborate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarekgh already pushed the change @richlander. No need to worry. We will make proper change later after more testing on new images.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I will be bringing in Debian 13, shortly. 24.10 will be replaced by 25.04 before long. My intent is to keep us closer to tip.

@stephentoub
Copy link
Member

For now the test can be disabled to unblock the pr.

@tarekgh tarekgh mentioned this pull request Jan 20, 2025
Open
@tarekgh
Copy link
Member

tarekgh commented Jan 20, 2025

I submitted a commit to disable the test to unblock the PR.

CC @wfurt

wfurt
wfurt approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jan 21, 2025
Open
Open
Open
Open
@tarekgh tarekgh merged commit 4974c12 into dotnet:main Jan 21, 2025
80 of 82 checks passed
@richlander
Copy link
Member Author

Thanks Everyone!

@richlander richlander mentioned this pull request Jan 30, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfurt wfurt wfurt approved these changes

@jkotas jkotas jkotas left review comments

@filipnavara filipnavara filipnavara left review comments

@carlossanlop carlossanlop carlossanlop left review comments

Assignees

@richlander richlander

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richlander @jkotas @tarekgh @filipnavara @stephentoub @carlossanlop @wfurt