[iOS][globalization] Revert of #107390 to allow the use of String.Replace #111534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 17, 2025
Open
matouskozak
requested review from
steveisok,
rmarinho,
akoeplinger,
ilonatommy and
vitek-karas
rmarinho
approved these changes
Jan 19, 2025
vitek-karas
approved these changes
Jan 19, 2025
ilonatommy
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #107390 to unblock MAUI upgrade to .NET 10 #111506.
Note that this will cause
IndexOf, in some cases, to return incorrectmatchLengthdue to normalization we use before calling Objective-CrangeOfStringAPI.We will investigate this further to implement a proper fix:
IndexOfdoesn't work correctly (doesn't find a match or reports incorrectmatchLength)IndexOfimplementation to remove preprocessing of strings (normalization, etc.)