[manual] Merge branch 'release/9.0' => 'release/9.0-staging' #111565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description Use explicit full-path for loading MsQuic.dll - it prevents accidental load of MsQuic.dll from another unintended directory (e.g. CWD = Current Working Directory) if the bundled MsQuic.dll fails to load (which can happen e.g. on WinServer 2012, where MsQuic is not supported). # Customer Impact Defense-in-depth # Regression No # Testing Targeted manual test on affected OS (Windows Server 2012), including self-contained and single-file publish scenarios. # Risk Low, changes are contained and have been thoroughly tested manually and in CI suite.
…bstract array types Jagged arrays in the payload can contain cycles. In that scenario, no value is correct for `ArrayRecord.FlattenedLength`, and `ArrayRecord.GetArray` does not have enough context to know how to handle the cycles. To address these issues, jagged array handling is simplified so that calling code can handle the cycles in the most appropriate way for the application. Single-dimension arrays can be represented in the payload using abstract types such as `IComparable[]` where the concrete element type is not known. When the concrete element type is known, `ArrayRecord.GetArray` could return either `SZArrayRecord<ClassRecord>` or `SZArrayRecord<object>`; without a concrete type, we need to return something that represents the element abstractly. 1. `ArrayRecord.FlattenedLength` is removed from the API 2. `ArrayRecord.GetArray` now returns `ArrayRecord[]` for jagged arrays instead of trying to populate them 3. `ArrayRecord.GetArray` now returns `SZArrayRecord<SerializationRecord>` for single-dimension arrays instead of either `SZArrayRecord<ClassRecord>` or `SZArrayRecord<object>`
* Fix Encoding regression * Feedback addressing * Fix the test --------- Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
[manual] Merge release/9.0-staging into release/9.0
…-merge-9.0-2025-01-14-1037
[manual] Merge release/9.0-staging into release/9.0 (second pass)
…, libClang.so is no longer found in the place we expect. As a result, the android aot offsets won't be generated and the dedicated CI leg will fail. (dotnet#111426) This change fixes the path.
…net#111467) * Support generic fields in PersistedAssemblyBuilder * Add the pragmas for unused fields * Add the pragmas for unused fields 2 * Fix test for the non-generic case * Re-use existing GetOriginalMemberIfConstructedType() --------- Co-authored-by: Steve Harter <[email protected]>
Update DIA to 17.12.0-beta1.24603.5 ---- #### AI description (iteration 1) #### PR Classification Dependency update #### PR Summary This pull request updates the version of the `MicrosoftDiaSymReaderNative` dependency. - `eng/Versions.props`: Updated `MicrosoftDiaSymReaderNativeVersion` to `17.12.0-beta1.24603.5`. Co-authored-by: Mirroring <[email protected]> Co-authored-by: Tom McDonald <[email protected]>
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the |
1 similar comment
|
Note regarding the |
hoyosjs
approved these changes
Jan 18, 2025
carlossanlop
added
Servicing-approved
|
/ba-g build timeouts and test bad exits. |
carlossanlop
merged commit e84969e
into
dotnet:release/9.0-staging
268 of 362 checks passed
This was referenced Jan 18, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###MERGE COMMIT!
This is the only manual PR intended from base to staging. It should be automated after this is merged since we updated the interbranch flow: #111549
cc @steveisok @hoyosjs