Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintenance-packages dependencies #112152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Feb 4, 2025

This PR is result of testing the parallel dependency updates to ensure source-build does not break: dotnet/dotnet#133

IMPORTANT: I need to merge this PR at the same time as all the other PRs in the other repos, to prevent breaking the dependency ingestion in the dotnet/sdk repo.

@carlossanlop carlossanlop added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure-libraries labels Feb 4, 2025
@carlossanlop carlossanlop self-assigned this Feb 4, 2025
@carlossanlop carlossanlop requested a review from a team February 6, 2025 17:34
@ericstj
Copy link
Member

ericstj commented Feb 19, 2025

Seems the build is failing because these versions are not available on any feed yet. Do we need to get these released first and mirrored to dotnet-public?

@carlossanlop carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 19, 2025
@carlossanlop
Copy link
Member Author

This is ready to review @ericstj @ViktorHofer

@carlossanlop carlossanlop changed the title Manually update maintenance-packages dependencies System.ValueTuple and System.Runtime.CompilerServices.Unsafe Manually update maintenance-packages dependencies Mar 19, 2025
@carlossanlop carlossanlop changed the title Manually update maintenance-packages dependencies Update maintenance-packages dependencies Mar 19, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 19, 2025

/__w/1/s/artifacts/sb/src/src/libraries/Microsoft.Extensions.Logging/src/Logger.cs(241,17): error CS0433: The type 'ReadOnlySpan' exists in both 'System.Memory, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'netstandard, Version=2.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' [/__w/1/s/artifacts/sb/src/src/libraries/Microsoft.Extensions.Logging/src/Microsoft.Extensions.Logging.csproj::TargetFramework=netstandard2.1]

src/libraries/System.Threading.Channels/ref/System.Threading.Channels.cs(51,47): error CS0433: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'ValueTask' exists in both 'System.Threading.Tasks.Extensions, Version=4.2.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'netstandard, Version=2.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

from the source-build job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants