Skip to content

Haiku: Initial runtime support #112323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Haiku: Initial runtime support #112323

wants to merge 2 commits into from

Conversation

trungnt2910
Copy link
Contributor

This contains a part of the code required to build CoreCLR and get paltests to pass on Haiku.

This commit covers native support code for the host and runtime libraries, which is located in src/native/**.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 10, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 10, 2025
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-native branch 3 times, most recently from b7782cc to 42aa6c8 Compare February 10, 2025 03:35
@huoyaoyuan huoyaoyuan added area-PAL-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 10, 2025
This was referenced Feb 10, 2025
Open
Open
Closed
Open
Open
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Feb 12, 2025
View reviewed changes
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Apr 7, 2025
View reviewed changes
trungnt2910 and others added 2 commits April 8, 2025 08:53
@trungnt2910
libs: Add back checks needed for Haiku
d5907da 
- Checks for non-POSIX headers: `HAVE_SYS_STATFS_H` and `HAVE_MNTENT_H`.
- Checks for `sizeof(dirent::d_name)`.
- Checks for non-standard `struct statvfs::f_basetype` member.

These were removed in dotnet#103441 but required for Haiku builds.
@trungnt2910 @jessicah
Haiku: Initial runtime support
1d6ffab 
This contains a part of the code required to build CoreCLR and get
`paltests` to pass on Haiku.

This commit covers native support code for the host and runtime
libraries, which is located in `src/native/**`.

Co-authored-by: Jessica Hamilton <[email protected]>
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-native branch from 3736ce0 to 1d6ffab Compare April 7, 2025 22:57
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 8, 2025
Open
Open
Open
Closed
@AaronRobinsonMSFT
Copy link
Member

@jkotas or @janvorli Any concerns with this community contribution? The code looks fine to me, but I've not gone through all the failing issues yet.

@jkotas
Copy link
Member

jkotas commented Apr 8, 2025

Any concerns with this community contribution?

Majority of the code modified in this PR is owned by libraries teams. They need to review and signoff.

@jkotas
Copy link
Member

jkotas commented Apr 8, 2025

It would be much easier to get these changes in if there is one PR per feature area (networking, crypto, I/O, interop, ...). PRs that cross many different feature areas require many different people for review that tends to take long time.

@jkotas
Copy link
Member

jkotas commented Apr 8, 2025

I've not gone through all the failing issues yet.

The test failures look related to the changes in the PR.

@trungnt2910
Copy link
Contributor Author

Seems like they're related to Linux SSL certs, which this PR isn't touching?

@jkotas
Copy link
Member

jkotas commented Apr 8, 2025

I do not see a failure like that in any other recent PRs.

@trungnt2910
Copy link
Contributor Author

trungnt2910 commented Apr 11, 2025 •
edited
Loading

It would be much easier to get these changes in if there is one PR per feature area (networking, crypto, I/O, interop, ...). PRs that cross many different feature areas require many different people for review that tends to take long time.

So should I split this PR into a bunch of very small ones, say:

How does that sound?

@jkotas
Copy link
Member

jkotas commented Apr 11, 2025

Yes, it would help to move this forward.

@trungnt2910
Copy link
Contributor Author

I've split most parts of this PR into what I have mentioned in the comment above, with updated links.

@jkotas
Copy link
Member

jkotas commented Apr 11, 2025

Superseded by the PRs above

@jkotas jkotas closed this Apr 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@jkotas jkotas jkotas left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

Assignees
No one assigned
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member os-haiku
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trungnt2910 @AaronRobinsonMSFT @jkotas @am11 @huoyaoyuan