[release/8.0-staging] remove extra assert from WinHttp handler #112861
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93984 to release/8.0-staging
/cc @ManickaP @wfurt
Customer Impact
Discovered in our CI, the issue is fixed since .NET 9. The problem is that from a certain Windows version, WinHTTP started calling the affected callback sometimes twice (we suspected it came with TLS 1.3). So the change now checks for the second call by checking whether
RequestHandle
is null or not. Technically the change just swapsassert
forif not null
.Note that I tried changes without product code impact without success in #112780.
Regression
Testing
CI, confirming that
WinHttpHandler
tests do not crash.Risk
Low. Firstly, this fix is out in 9.0 and 10.0. Secondly, it's very small change replacing
assert
withif not null
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.