Document NDK upgrade process #112885
Open
Document NDK upgrade process #112885
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkurdek
added
the
documentation
dotnet-issue-labeler
bot
added
the
needs-area-label
| ### 1. Verify the New NDK Version Locally | ||
| - Download the new NDK version. | ||
| - Test the local build using the new NDK by building a sample Android app. | ||
| - Ensure **AOT** and **AOT_WITH_LIBRARY_FILES** are enabled in the build. |
There was a problem hiding this comment.
The phrase 'Ensure AOT and AOT_WITH_LIBRARY_FILES are enabled in the build' could be clearer if 'AOT' is defined. Consider specifying what 'AOT' stands for.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
vcsjones
reviewed
Feb 24, 2025
| @@ -22,7 +22,7 @@ Android SDK and NDK can be automatically installed via the following script: | |||
| #!/usr/bin/env bash | |||
| set -e | |||
|
|
|||
| NDK_VER=r23c | |||
| NDK_VER=r27c | |||
There was a problem hiding this comment.
Should we update our codespaces container definition? (I can do it, just want to make sure its the right thing to do)
runtime/.devcontainer/android/Dockerfile
Line 31 in 2a19c9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR documents the process of upgrading the NDK on runtime CI.