Skip to content

ILLink: Respect DisableRuntimeMarshalling #113706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrvoorhe
Copy link
Contributor

The linker will no longer do additional marking in ProcessInteropMethod when the methods owning assembly has [assembly: System.Runtime.CompilerServices.DisableRuntimeMarshalling]

As requested #113437 (comment)

@mrvoorhe mrvoorhe requested a review from marek-safar as a code owner March 19, 2025 18:54
@ghost ghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Mar 19, 2025
@dotnet-policy-service dotnet-policy-service bot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Mar 19, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@mrvoorhe
Copy link
Contributor Author

fyi @jkotas @MichalStrehovsky @sbomer

The linker will no longer do additional marking in `ProcessInteropMethod` when the methods owning assembly has `[assembly: System.Runtime.CompilerServices.DisableRuntimeMarshalling]`
@mrvoorhe mrvoorhe force-pushed the linker-respect-disable-runtime-marshalling branch from e8ab5af to 1fe928b Compare March 19, 2025 19:40
@jkotas
Copy link
Member

jkotas commented Mar 20, 2025

This is effectively disabling the special handling for FCalls since CoreLib is marked with this attribute. The failing tests are very similar to #113704. We should probably investigate the failures #113704 first and then go back to this one once #113704 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants