Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase runtime-coreclr libraries-pgo timeout #113942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanasifkhalid
Copy link
Member

Up the timeout limit for libraries-pgo to accommodate Azure Linux 3 queues, which are timing out for several long-running tests in this pipeline (example run).

@Copilot Copilot bot review requested due to automatic review settings March 26, 2025 19:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout for the libraries-pgo job to help mitigate failures due to long-running tests on Azure Linux 3 queues.

  • Updated the timeout value from 660 to 690 minutes in the pipeline configuration.

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@jakobbotsch
Copy link
Member

Are we sure these aren't deadlocked?

It does not seem expected that tests like SslStream_StreamToStream_Authentication_IncorrectServerName_Fail take upwards of 30 minutes: https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-937db34dcfbd4359a6/System.Net.Security.Tests/1/console.f043299e.log?helixlogtype=result

cc @dotnet/ncl

@MihaZupan
Copy link
Member

MihaZupan commented Mar 26, 2025

Yes, these tests should be failing with timeouts after a minute or so if something went wrong. If they're stuck for several minutes like that they'll never complete.
Any chance you have a memory dump for one of these stuck tests?

@wfurt
Copy link
Member

wfurt commented Mar 27, 2025

There are two tasks and both should timeout...

                await Assert.ThrowsAsync<AuthenticationException>(() => t1.WaitAsync(TestConfiguration.PassingTestTimeout));
                try
                {
                    await t2.WaitAsync(TestConfiguration.PassingTestTimeout);
                }
                catch
                {
                    // Ignore outcome of t2. It can succeed or fail depending on timing.
                }

@JulieLeeMSFT
Copy link
Member

CC @hoyosjs on how to get memory dump on timeout tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants