-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase runtime-coreclr libraries-pgo
timeout
#113942
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR increases the timeout for the libraries-pgo job to help mitigate failures due to long-running tests on Azure Linux 3 queues.
- Updated the timeout value from 660 to 690 minutes in the pipeline configuration.
/azp run runtime-coreclr libraries-pgo |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @hoyosjs |
Are we sure these aren't deadlocked? It does not seem expected that tests like cc @dotnet/ncl |
Yes, these tests should be failing with timeouts after a minute or so if something went wrong. If they're stuck for several minutes like that they'll never complete. |
There are two tasks and both should timeout... await Assert.ThrowsAsync<AuthenticationException>(() => t1.WaitAsync(TestConfiguration.PassingTestTimeout));
try
{
await t2.WaitAsync(TestConfiguration.PassingTestTimeout);
}
catch
{
// Ignore outcome of t2. It can succeed or fail depending on timing.
} |
CC @hoyosjs on how to get memory dump on timeout tests. |
Up the timeout limit for
libraries-pgo
to accommodate Azure Linux 3 queues, which are timing out for several long-running tests in this pipeline (example run).