-
Notifications
You must be signed in to change notification settings - Fork 5.1k
TypeMap API (Dynamic implementation) #113954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AaronRobinsonMSFT
merged 25 commits into
dotnet:main
from
AaronRobinsonMSFT:type_map_impl
Apr 2, 2025
Merged
Changes from 12 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bd76011
TypeMap API (Dynamic implementation)
AaronRobinsonMSFT a2bfc27
Add basic tests
AaronRobinsonMSFT 7ed138b
Feedback and fixes from testing.
AaronRobinsonMSFT 2205ac8
Testing for all attributes
AaronRobinsonMSFT 91862d1
Convert Tuple<,> to private type.
AaronRobinsonMSFT cf32158
Feedback pass 1
AaronRobinsonMSFT 60e18c9
Always fallback and validate TypeSpec.
AaronRobinsonMSFT fb1e1a6
Handle exceptions from managed callbacks.
AaronRobinsonMSFT 04d9b10
Convert assert to explicit check for TypeSpec.
AaronRobinsonMSFT 49c5ad6
Delay parsing contents until needed.
AaronRobinsonMSFT 479c15b
Fix build
AaronRobinsonMSFT e7f9e6a
Call Return on ArrayPool array.
AaronRobinsonMSFT eb9e9e2
Remove unnecessary lock.
AaronRobinsonMSFT 380b809
Stop processing on error.
AaronRobinsonMSFT e94234f
Use GetMaxCharCount to estimate needed buffer length.
AaronRobinsonMSFT d2123d0
Perform type loading via the TypeNameResolver.GetTypeHelper API.
AaronRobinsonMSFT 7e99942
Move managed VersionResilientHashCode logic
AaronRobinsonMSFT 593f09e
Use newly shared VersionResilientHashCode logic.
AaronRobinsonMSFT 9ac6068
Remove TypeMapLazyDictionary.cs from mono build.
AaronRobinsonMSFT 51f8342
Remove unused message.
AaronRobinsonMSFT 697d7e1
Throw NotSupportedException for TypeMap APIs.
AaronRobinsonMSFT edf0a13
Feedback
AaronRobinsonMSFT 30148a3
Remove assert
AaronRobinsonMSFT 6c6e35c
Add message to SPCL.
AaronRobinsonMSFT 2713896
Remove unnecessary changes.
AaronRobinsonMSFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...stem.Private.CoreLib/src/System/Runtime/InteropServices/TypeMapAssemblyTargetAttribute.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System; | ||
|
||
namespace System.Runtime.InteropServices | ||
{ | ||
/// <summary> | ||
/// Declare an assembly that should be inspected during type map building. | ||
/// </summary> | ||
/// <typeparam name="TTypeMapGroup">Type map group</typeparam> | ||
[AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)] | ||
public sealed class TypeMapAssemblyTargetAttribute<TTypeMapGroup> : Attribute | ||
{ | ||
/// <summary> | ||
/// Provide the assembly to look for type mapping attributes. | ||
/// </summary> | ||
/// <param name="assemblyName">Assembly to reference</param> | ||
public TypeMapAssemblyTargetAttribute(string assemblyName) { } | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.